Skip to content

feat(Analysis/CStarAlgebra/ApproximateUnit): pure 1 is an increasing approx unit#40226

Open
themathqueen wants to merge 4 commits into
leanprover-community:masterfrom
themathqueen:approxunit_pure_one
Open

feat(Analysis/CStarAlgebra/ApproximateUnit): pure 1 is an increasing approx unit#40226
themathqueen wants to merge 4 commits into
leanprover-community:masterfrom
themathqueen:approxunit_pure_one

Conversation

@themathqueen
Copy link
Copy Markdown
Collaborator


Open in Gitpod

@themathqueen themathqueen added easy < 20s of review time. See the lifecycle page for guidelines. t-analysis Analysis (normed *, calculus) labels Jun 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

PR summary 98a4d20f0b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ pure_one

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 98a4d20).

  • +1 new declarations
  • −0 removed declarations
+Filter.IsIncreasingApproximateUnit.pure_one

No changes to strong technical debt.
No changes to weak technical debt.

Current commit 98a4d20f0b
Reference commit 07c7e6d228

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@themathqueen themathqueen temporarily deployed to cache-upload-forks June 4, 2026 14:55 — with GitHub Actions Inactive
@themathqueen themathqueen temporarily deployed to cache-upload-forks June 4, 2026 15:06 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant