Skip to content

feat: add zeta_sub_one_dvd_intCast_iff and related declarations#40232

Open
riccardobrasca wants to merge 1 commit into
leanprover-community:masterfrom
riccardobrasca:IsPrimitiveRoot_sub_one_dvd_sub
Open

feat: add zeta_sub_one_dvd_intCast_iff and related declarations#40232
riccardobrasca wants to merge 1 commit into
leanprover-community:masterfrom
riccardobrasca:IsPrimitiveRoot_sub_one_dvd_sub

Conversation

@riccardobrasca
Copy link
Copy Markdown
Member


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

PR summary 8097213929

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ sub_one_dvd_sub
+ zeta_sub_one_dvd_intCast_iff
+ zeta_sub_one_dvd_intCast_iff'

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 8097213).

  • +3 new declarations
  • −0 removed declarations
+IsCyclotomicExtension.Rat.zeta_sub_one_dvd_intCast_iff
+IsCyclotomicExtension.Rat.zeta_sub_one_dvd_intCast_iff'
+IsPrimitiveRoot.sub_one_dvd_sub

No changes to strong technical debt.
No changes to weak technical debt.

Current commit 8097213929
Reference commit 5135da2b75

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@riccardobrasca riccardobrasca temporarily deployed to cache-upload-forks June 4, 2026 16:29 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant