Skip to content

feat(RingTheory/Localization/Ideal): generalize IsLocalization.isMaximal_of_isMaximal_disjoint#41369

Open
tb65536 wants to merge 5 commits into
leanprover-community:masterfrom
tb65536:tb_dpr31
Open

feat(RingTheory/Localization/Ideal): generalize IsLocalization.isMaximal_of_isMaximal_disjoint#41369
tb65536 wants to merge 5 commits into
leanprover-community:masterfrom
tb65536:tb_dpr31

Conversation

@tb65536

@tb65536 tb65536 commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

This PR generalizes the existing IsLocalization.isMaximal_of_isMaximal_disjoint in RingTheory/Jacobson/Ring to arbitrary localizations.


Open in Gitpod

@tb65536 tb65536 requested a review from erdOne July 4, 2026 20:51
@tb65536 tb65536 added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-algebra Algebra (groups, rings, fields, etc) t-ring-theory Ring theory labels Jul 4, 2026
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown

PR summary 1d2f0802ae

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ IsLocalization.isMaximal_of_isMaximal_notMem
+ isMaximal_of_isMaximal_disjoint
+ isMaximal_of_isMaximal_under
- IsLocalization.isMaximal_of_isMaximal_disjoint

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 1d2f080).

  • +2 new declarations
  • −0 removed declarations
+IsLocalization.isMaximal_of_isMaximal_notMem
+IsLocalization.isMaximal_of_isMaximal_under

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 1d2f0802ae
Reference commit d3716e6d2e

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc) t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant