Skip to content

feat(Data/ENat/Basic): coe versions of m + 1 ≤ n ↔ m < n#41372

Open
SnirBroshi wants to merge 1 commit into
leanprover-community:masterfrom
SnirBroshi:feature/data/enat-succ-le-lt-iff-coe
Open

feat(Data/ENat/Basic): coe versions of m + 1 ≤ n ↔ m < n#41372
SnirBroshi wants to merge 1 commit into
leanprover-community:masterfrom
SnirBroshi:feature/data/enat-succ-le-lt-iff-coe

Conversation

@SnirBroshi

Copy link
Copy Markdown
Collaborator

Nat.cast specializations of add_one_le_iff/add_one_le_iff'/lt_add_one_iff' (the lt_add_one_iff version already exists).
These are helpful with simp-like tactics which don't like the ≠ ⊤ side condition.


Open in Gitpod

@github-actions github-actions Bot added the t-data Data (lists, quotients, numbers, etc) label Jul 4, 2026
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown

PR summary 4611423b5e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ add_one_le_coe_iff
+ coe_add_one_le_iff
+ coe_lt_add_one_iff

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 4611423).

  • +3 new declarations
  • −0 removed declarations
+ENat.add_one_le_coe_iff
+ENat.coe_add_one_le_iff
+ENat.coe_lt_add_one_iff

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 4611423b5e
Reference commit d3716e6d2e

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant