chore: remove redundant backward.privateInPublic exceptions#41395
chore: remove redundant backward.privateInPublic exceptions#41395felixpernegger wants to merge 13 commits into
Conversation
|
This pull request is now in draft mode. No active bors state needed cleanup. While this PR remains draft, bors will ignore commands on this PR. Mark it ready for review before using commands like |
PR summary ebd0686e1eImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type (strong) |
|---|---|---|
| 683 | -57 | backward.privateInPublic |
Current commit ebd0686e1e
Reference commit 62aaa5c959
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
There was a problem hiding this comment.
All added lines come from this file, because we replace the global setting, so this really doesnt increase tech debt.
There was a problem hiding this comment.
Makes sense, I'll happily merge a separate PR making this change. Hopefully, splice-bot will create such a PR for me.
There was a problem hiding this comment.
Split PR created
Split off the changes to Mathlib/CategoryTheory/ComposableArrows/Basic.lean in #41407.
There was a problem hiding this comment.
There lemmas called some error (not sure why), but since they are outdated anyways, i just removed them
|
!bench |
|
Benchmark results for f4e5f0c against e2361c1 are in. No significant results found. @felixpernegger
No significant changes detected. |
Co-authored-by: Felix Pernegger <s59fpern@uni-bonn.de>
|
This PR/issue depends on: |
Remove all
set_option backward.privateInPublic falsewhich are not needed, excluding MathlibTestbackward.privateInPublic.warnexceptions #41382