Skip to content

chore: remove redundant backward.privateInPublic exceptions#41395

Open
felixpernegger wants to merge 13 commits into
leanprover-community:masterfrom
felixpernegger:privateimprtextended
Open

chore: remove redundant backward.privateInPublic exceptions#41395
felixpernegger wants to merge 13 commits into
leanprover-community:masterfrom
felixpernegger:privateimprtextended

Conversation

@felixpernegger

@felixpernegger felixpernegger commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Remove all set_option backward.privateInPublic false which are not needed, excluding MathlibTest


Open in Gitpod

@felixpernegger felixpernegger marked this pull request as draft July 6, 2026 02:58
@mathlib-bors

mathlib-bors Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

This pull request is now in draft mode. No active bors state needed cleanup.

While this PR remains draft, bors will ignore commands on this PR. Mark it ready for review before using commands like bors r+ or bors try.

@github-actions github-actions Bot added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

PR summary ebd0686e1e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

- isoOfComponents_hom_hom_app
- isoOfComponents_inv_hom_app

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit ebd0686).

  • +0 new declarations
  • −2 removed declarations
-CategoryTheory.LaxBraidedFunctor.isoOfComponents_hom_hom_app
-CategoryTheory.LaxBraidedFunctor.isoOfComponents_inv_hom_app

Decrease in strong tech debt: (relative, absolute) = (57.00, 0.08)
Current number Change Type (strong)
683 -57 backward.privateInPublic
No changes to weak technical debt.

Current commit ebd0686e1e
Reference commit 62aaa5c959

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jul 6, 2026

@felixpernegger felixpernegger Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All added lines come from this file, because we replace the global setting, so this really doesnt increase tech debt.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

splice-bot

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I'll happily merge a separate PR making this change. Hopefully, splice-bot will create such a PR for me.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split PR created

Split off the changes to Mathlib/CategoryTheory/ComposableArrows/Basic.lean in #41407.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There lemmas called some error (not sure why), but since they are outdated anyways, i just removed them

@felixpernegger felixpernegger marked this pull request as ready for review July 6, 2026 06:05
@felixpernegger

Copy link
Copy Markdown
Contributor Author

!bench

@leanprover-radar

leanprover-radar commented Jul 6, 2026

Copy link
Copy Markdown

Benchmark results for f4e5f0c against e2361c1 are in. No significant results found. @felixpernegger

  • build//instructions: -31.9G (-0.02%)

No significant changes detected.

mathlib-bors Bot pushed a commit that referenced this pull request Jul 6, 2026
…ckward.privateInPublic` option (#41407)

Extracted from #41395 by `@felixpernegger`.

Co-authored-by: felixpernegger <188575194+felixpernegger@users.noreply.github.com>
Comment thread Mathlib/Logic/Godel/GodelBetaFunction.lean Outdated
Comment thread Mathlib/Order/DirectedInverseSystem.lean Outdated
Comment thread Mathlib/Order/DirectedInverseSystem.lean Outdated
Co-authored-by: Felix Pernegger <s59fpern@uni-bonn.de>
@mathlib-dependent-issues mathlib-dependent-issues Bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jul 6, 2026
@mathlib-dependent-issues

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants