Skip to content

Rename Real rpow order lemmas#41396

Open
xixifusi1213-gif wants to merge 1 commit into
leanprover-community:masterfrom
xixifusi1213-gif:codex/rename-real-rpow-order-lemmas
Open

Rename Real rpow order lemmas#41396
xixifusi1213-gif wants to merge 1 commit into
leanprover-community:masterfrom
xixifusi1213-gif:codex/rename-real-rpow-order-lemmas

Conversation

@xixifusi1213-gif

@xixifusi1213-gif xixifusi1213-gif commented Jul 6, 2026

Copy link
Copy Markdown

Closes #13544.

This renames the Real.rpow order lemmas so the names indicate which argument is being varied:

  • _left for monotonicity/strict monotonicity in the base
  • _right for monotonicity/strict monotonicity in the exponent

The old Real names are kept as deprecated aliases, and downstream Real usages in Mathlib are updated to the new names. The public NNReal and ENNReal theorem names are intentionally left unchanged.

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

PR summary b02f12e711

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ rpow_le_rpow_iff_left
+ rpow_le_rpow_iff_left_of_exponent_neg
+ rpow_le_rpow_iff_right
+ rpow_le_rpow_iff_right_of_base_lt_one
+ rpow_le_rpow_left
+ rpow_le_rpow_left_of_exponent_nonpos
+ rpow_le_rpow_right
+ rpow_le_rpow_right_of_base_ge_one_or_le_one
+ rpow_le_rpow_right_of_base_le_one
+ rpow_le_rpow_right_of_base_le_one'
+ rpow_le_rpow_right_of_base_le_one_of_imp
+ rpow_lt_rpow_iff_left
+ rpow_lt_rpow_iff_left_of_exponent_neg
+ rpow_lt_rpow_iff_right
+ rpow_lt_rpow_iff_right_of_base_lt_one
+ rpow_lt_rpow_left
+ rpow_lt_rpow_left_of_exponent_neg
+ rpow_lt_rpow_right
+ rpow_lt_rpow_right_of_base_lt_one

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit b02f12e).

  • +19 new declarations
  • −0 removed declarations
+Real.rpow_le_rpow_iff_left
+Real.rpow_le_rpow_iff_left_of_exponent_neg
+Real.rpow_le_rpow_iff_right
+Real.rpow_le_rpow_iff_right_of_base_lt_one
+Real.rpow_le_rpow_left
+Real.rpow_le_rpow_left_of_exponent_nonpos
+Real.rpow_le_rpow_right
+Real.rpow_le_rpow_right_of_base_ge_one_or_le_one
+Real.rpow_le_rpow_right_of_base_le_one
+Real.rpow_le_rpow_right_of_base_le_one'
+Real.rpow_le_rpow_right_of_base_le_one_of_imp
+Real.rpow_lt_rpow_iff_left
+Real.rpow_lt_rpow_iff_left_of_exponent_neg
+Real.rpow_lt_rpow_iff_right
+Real.rpow_lt_rpow_iff_right_of_base_lt_one
+Real.rpow_lt_rpow_left
+Real.rpow_lt_rpow_left_of_exponent_neg
+Real.rpow_lt_rpow_right
+Real.rpow_lt_rpow_right_of_base_lt_one

No changes to strong technical debt.

No changes to weak technical debt.

Current commit b02f12e711
Reference commit e2361c1beb

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@xixifusi1213-gif xixifusi1213-gif marked this pull request as ready for review July 6, 2026 05:29
@grunweg

grunweg commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Hello from triage! Can you comment on whether you used AI for this project? Thanks!
(Per mathlib's AI policy, this is not forbidden in principle, but its usage must be disclosed.)

@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes. label Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename rpow_le_rpow

2 participants