Skip to content

feat(RingTheory): Ideal.span corollaries of Krull's height theorem#41401

Open
vlad902 wants to merge 1 commit into
leanprover-community:masterfrom
vlad902:krull-corollaries
Open

feat(RingTheory): Ideal.span corollaries of Krull's height theorem#41401
vlad902 wants to merge 1 commit into
leanprover-community:masterfrom
vlad902:krull-corollaries

Conversation

@vlad902

@vlad902 vlad902 commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Currently we have statements bounding the height of minimal primes of Ideal.span s. Add the obvious corollaries to bound the height of Ideal.span s directly.

Also add a Set.encard-valued statement of Krulls' height theorem for Ideal.spans. In a Noetherian ring we know the bound should always be finite, but this is useful in downstream applications that are using ENats.


Open in Gitpod

@github-actions github-actions Bot added the t-ring-theory Ring theory label Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

PR summary 4ee7bece56

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ Ideal.height_le_encard_of_mem_minimalPrimes_span
+ Ideal.height_le_ncard_of_mem_minimalPrimes_span
+ Ideal.height_span_le_card_of_span_ne_top
+ Ideal.height_span_le_encard_of_span_ne_top
+ Ideal.height_span_le_ncard_of_span_ne_top

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 4ee7bec).

  • +5 new declarations
  • −0 removed declarations
+Ideal.height_le_encard_of_mem_minimalPrimes_span
+Ideal.height_le_ncard_of_mem_minimalPrimes_span
+Ideal.height_span_le_card_of_span_ne_top
+Ideal.height_span_le_encard_of_span_ne_top
+Ideal.height_span_le_ncard_of_span_ne_top

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 4ee7bece56
Reference commit 85ce110e6b

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Currently we have statements bounding the height of minimal primes of
`Ideal.span s`. Add the obvious corollaries to bound the height of
`Ideal.span s` directly.

Also add a `Set.encard`-valued statement of Krulls' height theorem for
`Ideal.span`s. In a Noetherian ring we know the bound should always be
finite, but this is useful in downstream applications that are using
ENats.
@vlad902 vlad902 force-pushed the krull-corollaries branch from e900534 to 4ee7bec Compare July 6, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant