Skip to content

perf( Mathlib/CategoryTheory/Sites/LocallySurjective.lean): investigate removing transitive import#41406

Open
grunweg wants to merge 1 commit into
leanprover-community:masterfrom
grunweg:slow-import
Open

perf( Mathlib/CategoryTheory/Sites/LocallySurjective.lean): investigate removing transitive import#41406
grunweg wants to merge 1 commit into
leanprover-community:masterfrom
grunweg:slow-import

Conversation

@grunweg

@grunweg grunweg commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

#41222 exposed that removing one transitive import makes mathlib 300 * 10⁹ instructions slower (about 0.2%).
Let's confirm this in isolation - and if so, investigate! That's too large a performance cliff to ignore.


Open in Gitpod

@grunweg grunweg added WIP Work in progress awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jul 6, 2026
@grunweg

grunweg commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

!bench

@leanprover-radar

leanprover-radar commented Jul 6, 2026

Copy link
Copy Markdown

Benchmark results for f489137 against db5c6a6 are in. No significant results found. @grunweg

  • 🟥 build//instructions: +36.5G (+0.02%)

No significant changes detected.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

PR summary f489137514

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit f489137).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit f489137514
Reference commit db5c6a6667

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added t-category-theory Category theory and removed awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jul 6, 2026
@grunweg

grunweg commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Hm, strange. #41411 tries the same on top of #41222.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-category-theory Category theory WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants