refactor(QED): name odd anomaly-cancellation planes

[catlover-bot]

Summary

This PR addresses the odd-case naming part of #1046 by replacing the non-descriptive basis / basis! and P / P! distinction with the Unshifted and Shifted terminology discussed in the issue.

The two planes are now organized as:

• Unshifted: the plane using oddFst / oddSnd
• Shifted: the plane using oddShiftFst / oddShiftSnd

The main public names are now:

• Unshifted.basisAsCharges / Shifted.basisAsCharges
• Unshifted.basis / Shifted.basis
• Unshifted.planeCharges / Shifted.planeCharges
• Unshifted.planeLinSols / Shifted.planeLinSols

Associated component, ACC, value, and linear-independence lemmas were moved into the corresponding namespaces and renamed consistently. References in Odd/LineInCubic.lean and Odd/Parameterization.lean were updated accordingly.

No mathematical statements or proofs are intended to change; this PR is a naming/organization refactor only. File splitting and the even case are intentionally left for follow-up work.

Files changed

• Physlib/QFT/QED/AnomalyCancellation/Odd/BasisLinear.lean
• Physlib/QFT/QED/AnomalyCancellation/Odd/LineInCubic.lean
• Physlib/QFT/QED/AnomalyCancellation/Odd/Parameterization.lean

Validation

• lake build
• targeted builds for the three modified modules
• git diff --check
• lake exe lint_all --fast (no lint errors in the modified Odd files; repository-wide pre-existing style issues remain elsewhere)
• ./scripts/lint-style.sh
• confirmed no added sorry or axiom

Part of #1046.

[github-actions]

Thank you for this pull-request (PR). If this is your first PR, welcome to the community!

Below is what will happen next. Please read carefully if you are not familiar with the process. You may open other PRs while this one is being reviewed, and can stack PRs on top of each other, so don't let these steps slow you down.

1. Some automated checks will be run on your PR. You can see the results of these checks at the buttom of your PR page. If any of these checks fail, you will need to fix the issues before your PR can be merged. You can learn more about these here, including how to run them locally, which is sometimes quicker than relying on the GitHub Actions. If you have never had a PR merged before, you may have to wait for a reviewer to manually start these checks (this is for security).

2. A reviewer will look at your PR and may ask you to make changes. This may happen a couple of days after you submit your PR, so you may need to be patient. But it should not be longer than that - if it is please bring it to the attention of the community on the Zulip. The level of review will depend on where your PR is submitted. If it is submitted to ./Physlib or ./QuantumInfo, the review will be more thorough than if it is submitted to ./PhyslibAlpha. You can find out more about what the review process is looking for in our review guidelines. If a reviewer adds an awaiting-author label to your PR, address the review comments, then please remove that label by adding a comment with -awaiting-author. This helps us keep track of reviews.

3. The reviewer will either approve your PR, or request more changes (in which case we return to step 2). Once your PR is approved, it will be merged by a maintainer, this should happen shortly after approval, though you may get more comments at this stage.

Tip: The easiest way to get have a fast review is to submit a PR that is small and self-contained, and has clear documentation explaining why things are the way they are in your chages.

If you have any problems or questions, please reach out to the community on the Zulip.

[jstoobysmith]

This looks great! Many thanks for this first PR. I have approved, once the workflows finish, I will merge.