chore: update mathlib name in nightly-testing workflow#98
Merged
Conversation
Update the bump_toolchain_nightly-testing workflow to change the mathlib dependency name to mathlib-nightly-testing in addition to updating the rev. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on November 11
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| # Update the mathlib rev in lakefile.toml to use the nightly-testing tag | ||
|
|
||
| # Update the mathlib name and rev in lakefile.toml to use nightly-testing | ||
| sed -i "s/name = \"mathlib\"/name = \"mathlib-nightly-testing\"/" lakefile.toml |
There was a problem hiding this comment.
Bug: Sed Command Fails on Flexible TOML Formatting
The sed command updating the mathlib dependency name in lakefile.toml is overly strict. It assumes exact whitespace around the = and specific quote usage. This can cause it to silently fail if the file's formatting differs, leaving the dependency name unchanged while the rev updates, potentially leading to an inconsistent state and build failures.
thomaskwaring
pushed a commit
to thomaskwaring/cslib_SKI
that referenced
this pull request
Apr 6, 2026
## Summary - Updates `bump_toolchain_nightly-testing.yml` to change the mathlib dependency name from `mathlib` to `mathlib-nightly-testing` in `lakefile.toml` - This ensures the workflow correctly references the nightly-testing variant of mathlib, not just updating the rev ## Changes - Added `sed` command to update `name = "mathlib"` to `name = "mathlib-nightly-testing"` - This runs alongside the existing `rev` update ## Test plan - [ ] Verify the workflow runs successfully on the next scheduled execution or manual trigger - [ ] Confirm `lakefile.toml` on `nightly-testing` branch has both correct name and rev after workflow runs 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bump_toolchain_nightly-testing.ymlto change the mathlib dependency name frommathlibtomathlib-nightly-testinginlakefile.tomlChanges
sedcommand to updatename = "mathlib"toname = "mathlib-nightly-testing"revupdateTest plan
lakefile.tomlonnightly-testingbranch has both correct name and rev after workflow runs🤖 Generated with Claude Code