Skip to content

chore: update mathlib name in nightly-testing workflow #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kim-em merged 1 commit into from
Oct 14, 2025
Merged

chore: update mathlib name in nightly-testing workflow #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/bump_toolchain_nightly-testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,11 @@ jobs:
run: |
# Update lean-toolchain file
echo "leanprover/lean4:${RELEASE_TAG}" > lean-toolchain

# Update the mathlib rev in lakefile.toml to use the nightly-testing tag

# Update the mathlib name and rev in lakefile.toml to use nightly-testing
sed -i "s/name = \"mathlib\"/name = \"mathlib-nightly-testing\"/" lakefile.toml
Copy link
Copy Markdown

@cursor cursor Bot Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Sed Command Fails on Flexible TOML Formatting

The sed command updating the mathlib dependency name in lakefile.toml is overly strict. It assumes exact whitespace around the = and specific quote usage. This can cause it to silently fail if the file's formatting differs, leaving the dependency name unchanged while the rev updates, potentially leading to an inconsistent state and build failures.

Fix in Cursor Fix in Web

sed -i "s/rev = \"[^\"]*\"/rev = \"${NIGHTLY_TESTING_TAG}\"/" lakefile.toml

# Update dependencies
lake update

Expand Down