Skip to content

[#13956] feat: bound kernel recursion by maxRecDepth#3

Merged
Garmelon merged 6 commits into
masterfrom
adaptation-13956
Jul 8, 2026
Merged

[#13956] feat: bound kernel recursion by maxRecDepth#3
Garmelon merged 6 commits into
masterfrom
adaptation-13956

Conversation

@downstream-lean4

Copy link
Copy Markdown
Contributor

This is the adaptation PR for leanprover/lean4#13956.

@downstream-lean4 downstream-lean4 Bot added the adaptation This is an adaptation PR for a PR in the lean4 repository. label Jul 6, 2026
@Garmelon Garmelon force-pushed the adaptation-13956 branch 3 times, most recently from 4bec360 to c100038 Compare July 7, 2026 09:58
@downstream-lean4

downstream-lean4 Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Build Report

For commit Merge branch 'master' into adaptation-13956

Repo Critical Build Test Lint
ProofWidgets4 ⏭️
aesop ⏭️
batteries 🟥 🟥
import-graph ⏭️
lean4-cli ⏭️
mathlib4 🟥 🟥 🟥
plausible ⏭️
quote4 ⏭️
BibtexQuery ⏭️ ⏭️
LeanSearchClient 🟥 ⏭️
comparator ⏭️ ⏭️
cslib 🟥 🟥 🟥
doc-gen4 🟥 ⏭️ ⏭️
illuminate ⏭️
lean4-unicode-basic ⏭️
lean4export ⏭️
leansqlite 🟥 ⏭️
repl ⏭️ ⏭️
verso 🟥 🟥 ⏭️
verso-slides 🟥 ⏭️
verso-web-components 🟥 ⏭️ ⏭️

View run

@Garmelon Garmelon force-pushed the adaptation-13956 branch from c100038 to 8e68375 Compare July 7, 2026 11:16
@Garmelon Garmelon force-pushed the adaptation-13956 branch from 8e68375 to 65d8cad Compare July 7, 2026 11:20
Garmelon and others added 2 commits July 7, 2026 15:42
…ker`

`#13956` adapts kernel `addDeclCore` to take a `maxRecDepth` bound, which
broke `Lean4Checker.Replay`'s `env.replay'` call. The replay machinery is
now upstreamed into Lean core as `Lean.Environment.replay` (available via
`import Lean`), so drop the external `Lean4Checker` dependency and call the
core function directly.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@Garmelon

Garmelon commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

The import-graph failure is just a flaky test (hopefully fixed on downstream-lean4 master), and the mathlib failure also looks flaky.

@downstream-lean4

Copy link
Copy Markdown
Contributor Author

The automatic merge failed. @Kha, please fix any merge conflicts and merge this PR manually.

@downstream-lean4 downstream-lean4 Bot added the merge-required This PR should be merged manually by the author. label Jul 8, 2026
@Garmelon Garmelon merged commit c9ecf2f into master Jul 8, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adaptation This is an adaptation PR for a PR in the lean4 repository. merge-required This PR should be merged manually by the author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants