Skip to content

chore: standardize on '@/' style paths#56

Merged
robsimmons merged 5 commits into
mainfrom
standardize-on-nonrelative-paths
Jul 3, 2026
Merged

chore: standardize on '@/' style paths#56
robsimmons merged 5 commits into
mainfrom
standardize-on-nonrelative-paths

Conversation

@robsimmons

Copy link
Copy Markdown
Collaborator

Enforced in vscode settings, checked in eslint. Is this something we want @Vtec234 ?

@robsimmons robsimmons requested a review from Vtec234 July 3, 2026 17:52
@robsimmons robsimmons force-pushed the standardize-on-nonrelative-paths branch 2 times, most recently from 0c0aa43 to f39a2b9 Compare July 3, 2026 18:00
enforced in vscode settings, checked in eslint
@robsimmons robsimmons force-pushed the standardize-on-nonrelative-paths branch from 58523da to d3add38 Compare July 3, 2026 18:03

@Vtec234 Vtec234 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still allows ./actions, right? Seems nice to indicate UI-backend grouping like that.

Comment thread .vscode/settings.json Outdated
Comment thread eslint.config.mjs Outdated
robsimmons and others added 2 commits July 3, 2026 19:02
Co-authored-by: Wojciech Nawrocki <13901751+Vtec234@users.noreply.github.com>
@robsimmons

Copy link
Copy Markdown
Collaborator Author

./actions is allowed, but the vscode setting will automatically add @/path/from/root/actions not ./actions. I'd be perfectly happy to back out of that .vscode/settings.json change.

@Vtec234

Vtec234 commented Jul 3, 2026

Copy link
Copy Markdown
Member

If we back out of the VSCode setting, will eslint still auto-fix ../actions? Either choice seems fine.

@robsimmons

Copy link
Copy Markdown
Collaborator Author

If we back out of the VSCode setting, will eslint still auto-fix ../actions?

yes, it will, just confirmed that. I'll back out of the vscode settings change — vscode will add relative paths and then eslint commit hook will fix the ones that need it

@robsimmons robsimmons merged commit 3154d99 into main Jul 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants