chore: eslint integration cleanup - #76
Open
robsimmons wants to merge 2 commits into
Open
Conversation
robsimmons
changed the title
robsimmons
force-pushed
the
push-mswmywwtswsq
branch
from
August 7, 2026 20:30
3658ee5 to
138b63a
Compare
robsimmons
force-pushed
the
push-mswmywwtswsq
branch
from
August 7, 2026 21:14
138b63a to
8af507f
Compare
robsimmons
force-pushed
the
push-mswmywwtswsq
branch
2 times, most recently
from
August 7, 2026 21:18
9b1cf07 to
3b0e8de
Compare
robsimmons
force-pushed
the
push-mswmywwtswsq
branch
from
August 7, 2026 21:44
3b0e8de to
cb40312
Compare
Vtec234
approved these changes
Aug 8, 2026
| // Stream seed events whenever we're in the seeding phase. | ||
| useEffect(() => { | ||
| if (phase !== 'seeding') return | ||
| if (phase !== 'seeding') return undefined |
Member
There was a problem hiding this comment.
I wouldn't want to worry about this manually, but if it can be auto-fixed in the husky hook then idm.
Collaborator
Author
There was a problem hiding this comment.
eh, not worth it and it seems like whatever lint rule prompted this isn't anymore, so I backed out of this change
… them Update src/lib/server/vscodeServer.ts Co-authored-by: Wojciech Nawrocki <13901751+Vtec234@users.noreply.github.com>
robsimmons
force-pushed
the
push-mswmywwtswsq
branch
from
August 9, 2026 02:31
cb40312 to
c15cd44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple and mechanical changes, like adding
!assertions where we can reason about something being non-null, that made sense to factor out of the hairier #75