feat: adapt non-equality theorems in mkTheoremFromDecl#13041
Merged
leodemoura merged 1 commit intomasterfrom Mar 22, 2026
Merged
feat: adapt non-equality theorems in mkTheoremFromDecl#13041leodemoura merged 1 commit intomasterfrom
mkTheoremFromDecl#13041leodemoura merged 1 commit intomasterfrom
Conversation
`mkTheoremFromDecl` and `mkTheoremFromExpr` now handle theorems whose conclusion is not an equality: - `¬ p` → adapted to `p = False` via `eq_false` - `p ↔ q` → adapted to `p = q` via `propext` - `p` (proposition) → adapted to `p = True` via `eq_true` This enables `Sym.simp` to use hypotheses like `h : p x` as rewrite rules that replace `p x` with `True`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
leodemoura
added a commit
that referenced
this pull request
Mar 22, 2026
The `simp` tactic in `sym =>` mode now resolves identifiers in the extra theorem list against local hypotheses first, falling back to global constants. Local hypotheses are adapted via `mkTheoremFromExpr` (using the `eq_true`/`eq_false`/`propext` adapter from #13041). - Add `ExtraTheorem` inductive (`.const` / `.fvar`) for cache keying - Add `resolveExtraTheorem` that checks the local context before globals - Update `addExtraTheorems`, `mkDefaultMethods`, `elabVariant` signatures Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 22, 2026
This PR extends the `simp` tactic in `sym =>` mode to support local hypotheses in the extra theorem list. `simp myVariant [h]` now resolves `h` against the local context first, falling back to global constants. Local hypotheses are converted to rewrite rules via `mkTheoremFromExpr`, which applies the `eq_true`/ `eq_false`/`propext` adapter from #13041. - Add `ExtraTheorem` inductive (`.const` / `.fvar`) for cache keying - Add `resolveExtraTheorems` that checks the local context before globals - Update `addExtraTheorems`, `mkDefaultMethods`, `elabVariant` signatures Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends
mkTheoremFromDeclandmkTheoremFromExprto handletheorems whose conclusion is not an equality, enabling
Sym.simpto usea broader class of lemmas as rewrite rules.
Adaptations:
¬ p→p = Falseviaeq_falsep ↔ q→p = qviapropextp(proposition) →p = Trueviaeq_trueConjunctions (
p ∧ q) are not handled here since theSymME-graphaggressively splits them via case analysis.