feat: support local hypotheses in simp [h] for sym => mode#13042
Merged
leodemoura merged 1 commit intomasterfrom Mar 22, 2026
Merged
feat: support local hypotheses in simp [h] for sym => mode#13042leodemoura merged 1 commit intomasterfrom
simp [h] for sym => mode#13042leodemoura merged 1 commit intomasterfrom
Conversation
The `simp` tactic in `sym =>` mode now resolves identifiers in the extra theorem list against local hypotheses first, falling back to global constants. Local hypotheses are adapted via `mkTheoremFromExpr` (using the `eq_true`/`eq_false`/`propext` adapter from #13041). - Add `ExtraTheorem` inductive (`.const` / `.fvar`) for cache keying - Add `resolveExtraTheorem` that checks the local context before globals - Update `addExtraTheorems`, `mkDefaultMethods`, `elabVariant` signatures Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the
simptactic insym =>mode to support localhypotheses in the extra theorem list.
simp myVariant [h]now resolveshagainst the local context first,falling back to global constants. Local hypotheses are converted to
rewrite rules via
mkTheoremFromExpr, which applies theeq_true/eq_false/propextadapter from #13041.ExtraTheoreminductive (.const/.fvar) for cache keyingresolveExtraTheoremsthat checks the local context before globalsaddExtraTheorems,mkDefaultMethods,elabVariantsignatures