Skip to content

chore: improve diagnostics when thread creation fails - #14082

Merged
Kha merged 5 commits into
leanprover:masterfrom
eric-wieser:pthread-errors
Jul 21, 2026
Merged

chore: improve diagnostics when thread creation fails#14082
Kha merged 5 commits into
leanprover:masterfrom
eric-wieser:pthread-errors

Conversation

@eric-wieser

@eric-wieser eric-wieser commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR includes the OS-level failure messages in the crash message when thread creation fails.

It also prevents some std::function objects being leaked in this failure case, and slightly cleans up some use of unique_ptr.

Kha
Kha requested changes Jun 23, 2026
View reviewed changes
Comment thread src/runtime/thread.cpp Outdated
eric-wieser
eric-wieser commented Jun 23, 2026
View reviewed changes
Comment thread src/runtime/thread.cpp Outdated
@eric-wieser
eric-wieser requested a review from Kha June 23, 2026 18:00
@Kha Kha added the awaiting-author Waiting for PR author to address issues label Jun 25, 2026
@github-actions github-actions Bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jul 21, 2026
@mathlib-lean-pr-testing

mathlib-lean-pr-testing Bot commented Jul 21, 2026

Copy link
Copy Markdown

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 7c8494ef0b9e5e72681449535f9ccdf5f543b4f5 --onto 323137b022369d56a044ae5af01d1efd55872361. You can force Mathlib CI using the force-mathlib-ci label. (2026-07-21 01:55:33)

@leanprover-bot

leanprover-bot commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 7c8494ef0b9e5e72681449535f9ccdf5f543b4f5 --onto 49ff95727f98d43984726b26742d17a1ceea9dd5. You can force reference manual CI using the force-manual-ci label. (2026-07-21 01:55:35)

@eric-wieser

eric-wieser commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

-awaiting-author

@Kha Kha added the release-ci Enable all CI checks for a PR, like is done for releases label Jul 21, 2026
@Kha
Kha enabled auto-merge July 21, 2026 12:14
@Kha
Kha added this pull request to the merge queue Jul 21, 2026
Merged via the queue into leanprover:master with commit 0e8a9eb Jul 21, 2026
30 of 33 checks passed
robsimmons pushed a commit that referenced this pull request Jul 29, 2026
@eric-wieser @robsimmons
chore: improve diagnostics when thread creation fails (#14082)
2d4c9a2 
This PR includes the OS-level failure messages in the crash message when
thread creation fails.

It also prevents some `std::function` objects being leaked in this
failure case, and slightly cleans up some use of `unique_ptr`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kha Kha Awaiting requested review from Kha

Assignees

No one assigned

Labels

awaiting-author Waiting for PR author to address issues release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eric-wieser @leanprover-bot @Kha