feat: make tactic set_option incremental - #14397
Merged
Merged
Conversation
This PR makes the `set_option ... in` tactic support incremental elaboration, so edits inside its tactic block reuse the results of unchanged leading tactics instead of re-running the whole block. Reuse is narrowed to the body tactic sequence, so changing the option name or value disables reuse. Incrementality is disabled for `set_option diagnostics in` as partial reuse would make the diagnostic report emitted at the end of the tactic incomplete. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Kha
enabled auto-merge
July 15, 2026 11:42
github-actions
Bot
added
toolchain-available
leanprover-bot
added
the
builds-manual
Collaborator
|
Reference manual CI status:
|
mathlib-lean-pr-testing
Bot
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
wrenna-robson
pushed a commit
to wrenna-robson/lean4
that referenced
this pull request
Jul 17, 2026
This PR makes the `set_option ... in` tactic support incremental elaboration, so edits inside its tactic block reuse the results of unchanged leading tactics instead of re-running the whole block. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
robsimmons
pushed a commit
that referenced
this pull request
Jul 29, 2026
This PR makes the `set_option ... in` tactic support incremental elaboration, so edits inside its tactic block reuse the results of unchanged leading tactics instead of re-running the whole block. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
set_option ... intactic support incremental elaboration, so edits inside its tactic block reuse the results of unchanged leading tactics instead of re-running the whole block.