fix: restore sharing for discharged hypothesis proofs that occur in the result in Sym.simp - #14424
Merged
Conversation
Member
Author
|
!bench |
|
Benchmark results for afb4f7d against 94b4a6e are in. No significant results found. @leodemoura
Medium changes (1✅, 1🟥)
Small changes (3🟥)
|
robsimmons
pushed a commit
that referenced
this pull request
Jul 29, 2026
…he result in `Sym.simp` (#14424) This PR fixes a maximal-sharing violation in `Sym.simp`: when a conditional rewrite discharged a hypothesis that occurs in the theorem's right-hand side., the discharger-provided proof was spliced into the resulting term without restoring maximal sharing, violating the `SymM` sharing invariant (detected by `sym.debug`). Dischargers are not required to return maximally shared proofs. This issue was reported by @hargoniX `Theorem` now stores `rhsVarMask`, a bitmask computed once at theorem construction that records which theorem variables occur in the right-hand side. During rewriting, `Theorem.rewrite` applies `shareCommon` to a discharged hypothesis proof only when the corresponding bit is set, i.e., only when the proof becomes part of the resulting term.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a maximal-sharing violation in
Sym.simp: when a conditional rewrite discharged a hypothesis that occurs in the theorem's right-hand side., the discharger-provided proof was spliced into the resulting term without restoring maximal sharing, violating theSymMsharing invariant (detected bysym.debug). Dischargers are not required to return maximally shared proofs. This issue was reported by @hargoniXTheoremnow storesrhsVarMask, a bitmask computed once at theorem construction that records which theorem variables occur in the right-hand side. During rewriting,Theorem.rewriteappliesshareCommonto a discharged hypothesis proof only when the corresponding bit is set, i.e., only when the proof becomes part of the resulting term.