feat: validate [grind homo] theorems - #14452
Merged
Merged
Conversation
This PR rejects `[grind homo]` theorems that cannot be applied as rewrite rules: instance-implicit parameters may be omitted from the left-hand side (they are synthesized during rewriting), but any other parameter must be determined by it. Conditional theorems are rejected with an error pointing to the E-matching attributes. The `reset_grind_attrs%` command now also clears the `[grind homo]` and `[grind homo_pred]` extensions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
leodemoura
enabled auto-merge
July 19, 2026 18:40
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Jul 19, 2026
leodemoura
enabled auto-merge
July 19, 2026 19:11
robsimmons
pushed a commit
that referenced
this pull request
Jul 29, 2026
This PR rejects `[grind homo]` theorems that are conditional rewriting rules. Conditional theorems are rejected with an error pointing to the E-matching attributes. The `reset_grind_attrs%` command now also clears the `[grind homo]` and `[grind homo_pred]` extensions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rejects
[grind homo]theorems that are conditional rewriting rules. Conditional theorems are rejected with an error pointing to the E-matching attributes. Thereset_grind_attrs%command now also clears the[grind homo]and[grind homo_pred]extensions.🤖 Generated with Claude Code