fix: activate CompleteLattice→CCPO under open Std.Internal.Do - #14502
Merged
Conversation
This PR scopes `Lean.Order.instCCPO_std` into `Std.Internal.Do` so Hoare triple notation (which defaults the exception postcondition to `⊥`) elaborates after `open Std.Internal.Do` without also requiring `open Lean.Order`. Co-authored-by: Cursor <cursoragent@cursor.com>
sgraf812
marked this pull request as ready for review
July 22, 2026 14:44
sgraf812
enabled auto-merge
July 22, 2026 14:44
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
robsimmons
pushed a commit
that referenced
this pull request
Jul 29, 2026
This PR scopes `Lean.Order.instCCPO_std` into `Std.Internal.Do` so Hoare triple notation (which defaults the exception postcondition to `⊥`) elaborates after `open Std.Internal.Do` without also requiring `open Lean.Order`. Previously `⦃ P ⦄ x ⦃ Q ⦄` expanded to `Triple … Lean.Order.bot`, and synthesizing `CCPO` for the exception postcondition required the scoped `CompleteLattice → CCPO` instance from `Lean.Order`. Opening only `Std.Internal.Do` (as needed for the notation) left that instance inactive and failed with `failed to synthesize Lean.Order.CCPO EPost⟨⟩`. The fix uses `attribute [scoped instance]` so the same instance is also activated by `open Std.Internal.Do`. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR scopes
Lean.Order.instCCPO_stdintoStd.Internal.Doso Hoare triple notation (which defaults the exception postcondition to⊥) elaborates afteropen Std.Internal.Dowithout also requiringopen Lean.Order.Previously
⦃ P ⦄ x ⦃ Q ⦄expanded toTriple … Lean.Order.bot, and synthesizingCCPOfor the exception postcondition required the scopedCompleteLattice → CCPOinstance fromLean.Order. Opening onlyStd.Internal.Do(as needed for the notation) left that instance inactive and failed withfailed to synthesize Lean.Order.CCPO EPost⟨⟩. The fix usesattribute [scoped instance]so the same instance is also activated byopen Std.Internal.Do.