fix: vcgen equation specs for deep-embedding program types - #14530
Merged
Conversation
sgraf812
force-pushed
the
fix-vcgen-deep-embedding-eq-specs
branch
from
July 24, 2026 10:54
79a1494 to
87210f7
Compare
sgraf812
force-pushed
the
fix-vcgen-deep-embedding-eq-specs
branch
from
July 24, 2026 11:17
87210f7 to
42a0049
Compare
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
sgraf812
marked this pull request as ready for review
July 24, 2026 11:27
sgraf812
enabled auto-merge
July 24, 2026 11:27
sgraf812
disabled auto-merge
July 24, 2026 11:27
sgraf812
enabled auto-merge
July 24, 2026 11:31
robsimmons
pushed a commit
that referenced
this pull request
Jul 29, 2026
This PR fixes a panic in `vcgen` when an equation or unfold spec supplied via `vcgen [someDef]` is used for a program in a deep embedding, i.e. a program type with a bare `Std.Internal.Do.WP` instance rather than a monadic one. The fix unifies the equation's type with the goal's program type under first-order approximation at reducible transparency and reuses the goal's `wp` arguments (`info.args.take 7`) for the `wp_le_wp_of_eq` instantiation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a panic in
vcgenwhen an equation or unfold spec supplied viavcgen [someDef]is used for a program in a deep embedding, i.e. a program type with a bareStd.Internal.Do.WPinstance rather than a monadic one.The fix unifies the equation's type with the goal's program type under first-order approximation at reducible transparency and reuses the goal's
wparguments (info.args.take 7) for thewp_le_wp_of_eqinstantiation.