test: cover stream known-size initialization race - #14552
Open
kernelpanic888 wants to merge 2 commits into
Open
Conversation
This PR initializes stream size metadata before scheduling the producer, preventing a builder default from racing with and overwriting producer-provided fixed lengths. Closes leanprover#14527
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Author
|
Resolved the conflict with current |
Author
|
changelog-no |
kernelpanic888
marked this pull request as ready for review
August 11, 2026 00:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #14541 (commit
44d40a3d8c) has already fixed the race by initializing.chunkedinsideBody.streambefore the producer starts. This PR now keeps only the missing regression coverage for that implementation.The tests verify two boundaries:
Body.streamproducer observes.chunkedimmediately;.fixed 42size survives completion ofResponse.Builder.streamand is not overwritten.The branch is merged with current
master; it no longer adds or changes theBody.streamAPI.