Skip to content

fix: preserve expected types of nested proofs#14557

Draft
kernelpanic888 wants to merge 2 commits into
leanprover:masterfrom
kernelpanic888:codex/simp-hoisted-proof-14467
Draft

fix: preserve expected types of nested proofs#14557
kernelpanic888 wants to merge 2 commits into
leanprover:masterfrom
kernelpanic888:codex/simp-hoisted-proof-14467

Conversation

@kernelpanic888

Copy link
Copy Markdown

This PR preserves the expected application-domain type when abstracting nested proof terms, preventing simplification from leaking an unfolded implementation type into the generated auxiliary theorem.

The nested-proof traversal now propagates each function domain as the expected type of the corresponding argument. The public abstractProof API remains unchanged.

Closes #14467

Tests

  • Full stage1 rebuild: 5047/5047 jobs
  • build/14467-reuse/stage1/bin/lean tests/lean/simpHoistedProof.lean
  • git diff --check

@github-actions github-actions Bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jul 25, 2026
@mathlib-lean-pr-testing

Copy link
Copy Markdown

Mathlib CI status (docs):

  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2026-07-25 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. You can force Mathlib CI using the force-mathlib-ci label. (2026-07-25 21:46:18)

@leanprover-bot leanprover-bot added the breaks-manual This is not necessarily a blocker for merging, but there needs to be a plan. label Jul 25, 2026
@leanprover-bot

leanprover-bot commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

Reference manual CI status:

leanprover-bot added a commit to leanprover/reference-manual that referenced this pull request Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaks-manual This is not necessarily a blocker for merging, but there needs to be a plan. toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in v4.33.0-rc1: simp changes the type of hoisted proof

2 participants