Skip to content

feat: handle stacked dependent projections in cbv that compose into dependent projection - #14567

Merged
wkrozowski merged 2 commits into
leanprover:masterfrom
wkrozowski:wojciech/cbv_stacked_dep_projections
Jul 28, 2026
Merged

feat: handle stacked dependent projections in cbv that compose into dependent projection#14567
wkrozowski merged 2 commits into
leanprover:masterfrom
wkrozowski:wojciech/cbv_stacked_dep_projections

Conversation

@wkrozowski

Copy link
Copy Markdown
Contributor

This PR allows cbv to handle stacks of dependent projections, whose composite is non-dependent.

@wkrozowski wkrozowski added the changelog-language Language features and metaprograms label Jul 27, 2026
@wkrozowski

Copy link
Copy Markdown
Contributor Author

!bench

@leanprover-radar

leanprover-radar commented Jul 27, 2026

Copy link
Copy Markdown

Benchmark results for 172f0ea against 0bfc3ac are in. No significant results found. @wkrozowski

Warning

These warnings may indicate that the benchmark results are not directly comparable, for example due to changes in the runner configuration or hardware.

  • Bench repo commit hashes for run build differ between commits.
  • Bench repo commit hashes for run other differ between commits.
  • build//instructions: -704.6M (-0.01%)

Medium changes (1🟥)

  • 🟥 vcgen/PurePrecond/400/kernel//wall-clock: +9ms (+27.27%)

Small changes (4🟥)

  • 🟥 build/module/Init.Data.List.Nat//instructions: +11.6M (+2.24%)
  • 🟥 build/module/Lean.Meta.Tactic.Cbv.Main//instructions: +660.9M (+5.59%) (reduced significance based on *//lines)
  • 🟥 compiled/io_compute//task-clock: +90ms (+4.25%)
  • 🟥 compiled/io_compute//wall-clock: +90ms (+4.25%)

@github-actions github-actions Bot added toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN labels Jul 27, 2026
@leanprover-bot leanprover-bot added the builds-manual CI has verified that the Lean Language Reference builds against this PR label Jul 27, 2026
@leanprover-bot

leanprover-bot commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Reference manual CI status:

@mathlib-lean-pr-testing mathlib-lean-pr-testing Bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jul 27, 2026
@mathlib-lean-pr-testing

mathlib-lean-pr-testing Bot commented Jul 27, 2026

Copy link
Copy Markdown

Mathlib CI status (docs):

@wkrozowski
wkrozowski marked this pull request as ready for review July 28, 2026 10:20
@wkrozowski
wkrozowski requested a review from leodemoura as a code owner July 28, 2026 10:20
mathlib-nightly-testing Bot pushed a commit to leanprover-community/batteries that referenced this pull request Jul 28, 2026
mathlib-nightly-testing Bot pushed a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Jul 28, 2026
leanprover-bot added a commit to leanprover/reference-manual that referenced this pull request Jul 28, 2026
@wkrozowski
wkrozowski added this pull request to the merge queue Jul 28, 2026
Merged via the queue into leanprover:master with commit b1722ad Jul 28, 2026
23 checks passed
wkrozowski added a commit to marcelolynch/lean4 that referenced this pull request Jul 29, 2026
… dependent projection (leanprover#14567)

This PR allows `cbv` to handle stacks of dependent projections, whose
composite is non-dependent.
robsimmons pushed a commit that referenced this pull request Jul 29, 2026
… dependent projection (#14567)

This PR allows `cbv` to handle stacks of dependent projections, whose
composite is non-dependent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-manual CI has verified that the Lean Language Reference builds against this PR builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features and metaprograms mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants