chore: simplify bif to if - #14588
Merged
Merged
Conversation
|
The adaptation PR for this PR is leanprover/downstream-lean4#20. |
Member
Author
|
!radar |
|
Benchmark results for 44e5d21 against 0bfc3ac are in. No significant results found. @TwoFX Warning These warnings may indicate that the benchmark results are not directly comparable, for example due to changes in the runner configuration or hardware.
Medium changes (1🟥)
Small changes (1✅, 6🟥)
|
Collaborator
|
Reference manual CI status:
|
|
Mathlib CI status (docs):
|
TwoFX
marked this pull request as ready for review
July 30, 2026 06:25
TwoFX
enabled auto-merge
July 30, 2026 06:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR turns
cond_eq_iteinto asimplemma.This means that users of
condnow automatically benefit from the better lemma coverage ofite.We also prefer
ifoverbifin some definitions, establishing the pattern of usingiteinstead ofcondunless there is a demonstrated benefit to usingcond.