fix: apply beta when canonicalizing types in grind - #14709
Merged
Conversation
This PR ensures beta-reduction is applied when canonicalizing types in `grind`.
leodemoura
enabled auto-merge
August 6, 2026 20:40
leodemoura
disabled auto-merge
August 6, 2026 22:45
leodemoura
enabled auto-merge
August 6, 2026 22:45
kim-em
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Aug 7, 2026
Repairs 22 `grind` calls across 11 files. Three are hint-list changes only (`Perm/Fin`, `Gaps`, `DeltaZeroIter`); the rest supply a `Fin.val` fact or finite case analysis that the `ToInt` machinery used to put in the E-graph. `#adaptation_note`s mark the genuine workarounds, and flag the four sites whose diagnostics suggest leanprover/lean4#14709 (grind conflating two spellings of the same `Fin` type) rather than a missing `[grind hom]` rule. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CM7yQ5HjNMiMucvCud9RdT
leodemoura
disabled auto-merge
August 7, 2026 12:36
leodemoura
enabled auto-merge
August 7, 2026 12:36
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures beta-reduction is applied when canonicalizing types in
grind.