Skip to content

fix: String.Pos.Raw.extract model/runtime mismatch - #14717

Merged
TwoFX merged 6 commits into
leanprover:masterfrom
Rob23oba:string-extract-wrong
Aug 10, 2026
Merged

fix: String.Pos.Raw.extract model/runtime mismatch#14717
TwoFX merged 6 commits into
leanprover:masterfrom
Rob23oba:string-extract-wrong

Conversation

@Rob23oba

@Rob23oba Rob23oba commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

This PR the model/runtime mismatch in String.Pos.Raw.extract and adds a faster variant (lean_string_utf8_extract_fast) for String.extract that assumes that the positions are valid positions.

Closes #14684

@github-actions github-actions Bot added the changelog-compiler Compiler, runtime, and FFI label Aug 7, 2026
@Rob23oba
Rob23oba marked this pull request as ready for review August 7, 2026 20:14
@Rob23oba
Rob23oba requested a review from kim-em as a code owner August 7, 2026 20:14
@github-actions github-actions Bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 7, 2026
@mathlib-lean-pr-testing

Copy link
Copy Markdown

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 87e7204456bfca901bdc724c996030e13c2f80c6 --onto bd97ed8e35639e17a11d1490cbc46d994e7b4513. You can force Mathlib CI using the force-mathlib-ci label. (2026-08-07 20:36:56)

@leanprover-bot

Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 87e7204456bfca901bdc724c996030e13c2f80c6 --onto c4e6b62c3d955ef20da94310797072f7c4c5fa2b. You can force reference manual CI using the force-manual-ci label. (2026-08-07 20:36:58)

@TwoFX TwoFX left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TwoFX
TwoFX added this pull request to the merge queue Aug 10, 2026
Merged via the queue into leanprover:master with commit f7f5b4c Aug 10, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-compiler Compiler, runtime, and FFI toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

String.Pos.Raw.extract model/runtime mismatch and use-after-free

3 participants