Skip to content

feat: lake: cache get --package & stabilize --rev - #14724

Merged
tydeu merged 9 commits into
leanprover:masterfrom
tydeu:lake/cache-get-package
Aug 10, 2026
Merged

feat: lake: cache get --package & stabilize --rev#14724
tydeu merged 9 commits into
leanprover:masterfrom
tydeu:lake/cache-get-package

Conversation

@tydeu

@tydeu tydeu commented Aug 9, 2026

Copy link
Copy Markdown
Member

This PR adds the --package option for lake cache get, which fetches outputs for a specific package in the workspace (not just the root). This is particularly useful for downloading dependency outputs from a custom service. In addition, the undocumented --rev support has been removed from put and documented for put-staged.

The use of --rev for put can be a footgun because Lake uses the toolchain and platform information of the currently loaded package in put. For put-staged, however, where these elements must be provided, it makes perfect sense (and is already in use in downstream).

The PR also removes an unused, undocumented second positional argument for lake cache add to specify the package, changing this to the new --package and documenting that.

@tydeu tydeu added the changelog-lake Lake label Aug 9, 2026
@github-actions github-actions Bot added toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN labels Aug 9, 2026
@leanprover-bot

leanprover-bot commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Reference manual CI status:

@leanprover-bot leanprover-bot added the breaks-manual This is not necessarily a blocker for merging, but there needs to be a plan. label Aug 9, 2026
tydeu and others added 2 commits August 9, 2026 23:59
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@mathlib-lean-pr-testing mathlib-lean-pr-testing Bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Aug 10, 2026
@mathlib-lean-pr-testing

mathlib-lean-pr-testing Bot commented Aug 10, 2026

Copy link
Copy Markdown

Mathlib CI status (docs):

tydeu and others added 2 commits August 10, 2026 01:00
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
mathlib-nightly-testing Bot pushed a commit to leanprover-community/batteries that referenced this pull request Aug 10, 2026
mathlib-nightly-testing Bot pushed a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Aug 10, 2026
leanprover-bot added a commit to leanprover/reference-manual that referenced this pull request Aug 10, 2026
mathlib-nightly-testing Bot pushed a commit to leanprover-community/batteries that referenced this pull request Aug 10, 2026
mathlib-nightly-testing Bot pushed a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Aug 10, 2026
leanprover-bot added a commit to leanprover/reference-manual that referenced this pull request Aug 10, 2026
@tydeu
tydeu marked this pull request as ready for review August 10, 2026 03:09
mathlib-nightly-testing Bot pushed a commit to leanprover-community/batteries that referenced this pull request Aug 10, 2026
@tydeu
tydeu added this pull request to the merge queue Aug 10, 2026
mathlib-nightly-testing Bot pushed a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Aug 10, 2026
leanprover-bot added a commit to leanprover/reference-manual that referenced this pull request Aug 10, 2026
Merged via the queue into leanprover:master with commit 9b857eb Aug 10, 2026
20 checks passed
@tydeu
tydeu deleted the lake/cache-get-package branch August 10, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaks-manual This is not necessarily a blocker for merging, but there needs to be a plan. builds-mathlib CI has verified that Mathlib builds against this PR changelog-lake Lake mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants