task: adding connection params - #40
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds connection parameter support to the database connection functionality, allowing users to specify additional connection parameters that will be appended as URL query parameters to the connection string.
- Added a new
Paramsfunction to specify connection parameters in key-value format - Introduced a global
connParamsvariable to store encoded connection parameters - Refactored variable names in tests from
dbUrltourlfor consistency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| db/connection.go | Added Params function and connParams global variable to support appending connection parameters to the connection string |
| db/connection_test.go | Renamed dbUrl variables to url and added test case for connection parameters functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
db/connection.go:59
- The connection is being stored in
dbPoolusing the originalurlparameter (from the function signature), but the lookup at line 38 will also use this original URL. However, the actual connection is opened with the modified URL that includes parameters (line 54). This means connections with different parameters but the same base URL will incorrectly be treated as the same connection. The pooling key should incorporate the connection parameters or use the modified URL.
dbPool[url] = conn
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a db connection option to specify connection parameters.