Add session helper functions for value manipulation by paganotoni · Pull Request #45 · leapkit/core

paganotoni · 2026-01-11T14:28:30Z

Summary

This PR adds convenient helper functions to simplify session value operations in the server/session package:

session.Get(r, key) - retrieve a value from the session
session.Set(r, w, key, value) - store a value in the session
session.Delete(r, w, key) - remove a value from the session
session.Clear(r, w) - remove all values from the session
session.Save(r, w) - explicitly persist the session

Motivation

Previously, users had to:

Call session.FromCtx(r.Context()) to get the session
Directly manipulate the Values map

The new helpers provide a cleaner API and safer error handling - they return ErrSessionNotFound instead of panicking when the session is not in context.

Usage

// Set a value
err := session.Set(r, w, "user_id", "1234")

// Get a value
val, exists, err := session.Get(r, "user_id")

// Delete a value
err := session.Delete(r, w, "user_id")

// Clear all values
err := session.Clear(r, w)

// Explicitly save (useful for WebSocket/SSE scenarios)
err := session.Save(r, w)

Testing

Added comprehensive tests in values_test.go
All tests pass with 100% coverage
Verified with go vet and gofmt

Add convenient helper functions to simplify session value operations: - Get(r, key) - retrieve a value from the session - Set(r, w, key, value) - store a value in the session - Delete(r, w, key) - remove a value from the session - Clear(r, w) - remove all values from the session - Save(r, w) - explicitly persist the session All functions return ErrSessionNotFound if the session is not in context, providing safer error handling compared to FromCtx which panics.

Copilot

Pull request overview

This PR adds convenient helper functions to the server/session package to simplify session value manipulation. The new functions provide a cleaner API with explicit error handling instead of requiring users to call session.FromCtx and directly manipulate the Values map.

Changes:

Added five new helper functions: Get, Set, Delete, Clear, and Save for session value operations
Introduced ErrSessionNotFound error for safer error handling when session is not in context
Comprehensive test suite with 100% coverage for the new functionality

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 17 comments.

File	Description
server/session/values.go	Implements the new session helper functions with error handling and context validation
server/session/values_test.go	Comprehensive test suite covering all new functions including error cases and persistence scenarios

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-11T14:34:24Z

+		})
+
+		s.HandleFunc("GET /set/{$}", func(w http.ResponseWriter, r *http.Request) {
+			session.Set(r, w, "to_delete", "value")


The return value from session.Set is not checked for errors. While this call is unlikely to fail in this test context, it's a best practice to check all error returns in tests for consistency and to catch unexpected issues.

Copilot · 2026-01-11T14:34:24Z

+		})
+
+		s.HandleFunc("GET /delete/{$}", func(w http.ResponseWriter, r *http.Request) {
+			session.Delete(r, w, "to_delete")


The return value from session.Delete is not checked for errors. While this call is unlikely to fail in this test context, it's a best practice to check all error returns in tests for consistency and to catch unexpected issues.

Suggested change

session.Delete(r, w, "to_delete")

if err := session.Delete(r, w, "to_delete"); err != nil {

t.Errorf("Delete failed: %v", err)

}

Copilot · 2026-01-11T14:34:25Z

+			_, exists1, _ := session.Get(r, "key1")
+			_, exists2, _ := session.Get(r, "key2")


The error returns from session.Get calls are ignored using the blank identifier. While this may be acceptable if the test is only checking value existence, it's better practice to check the errors to catch unexpected issues. Consider adding error checking for consistency with other tests.

Suggested change

_, exists1, _ := session.Get(r, "key1")

_, exists2, _ := session.Get(r, "key2")

_, exists1, err := session.Get(r, "key1")

if err != nil {

t.Errorf("Get failed for key1: %v", err)

}

_, exists2, err := session.Get(r, "key2")

if err != nil {

t.Errorf("Get failed for key2: %v", err)

}

Copilot · 2026-01-11T14:34:25Z

+// Delete removes a value from the session by key.
+// Returns an error if the session is not in the request context.


The documentation should clarify that sessions are automatically saved when the response is written via the saver middleware, and that this function only modifies the session in memory. Add a note similar to the one in the Save function documentation to explain when/how the session is persisted.

Copilot · 2026-01-11T14:34:25Z

+			session.Set(r, w, "key1", "value1")
+			session.Set(r, w, "key2", "value2")
+			session.Set(r, w, "key3", "value3")


The return values from session.Set calls are not checked for errors. While these calls are unlikely to fail in this test context, it's a best practice to check all error returns in tests for consistency and to catch unexpected issues. Consider adding error checks similar to those used elsewhere in the test file.

Suggested change

session.Set(r, w, "key1", "value1")

session.Set(r, w, "key2", "value2")

session.Set(r, w, "key3", "value3")

if err := session.Set(r, w, "key1", "value1"); err != nil {

t.Fatalf("Set failed: %v", err)

}

if err := session.Set(r, w, "key2", "value2"); err != nil {

t.Fatalf("Set failed: %v", err)

}

if err := session.Set(r, w, "key3", "value3"); err != nil {

t.Fatalf("Set failed: %v", err)

}

Copilot · 2026-01-11T14:34:27Z

+
+// Delete removes a value from the session by key.
+// Returns an error if the session is not in the request context.
+func Delete(r *http.Request, w http.ResponseWriter, key string) error {


The w http.ResponseWriter parameter is accepted but never used in this function. While it may be included for API consistency, this could confuse users. Consider either removing this parameter or documenting clearly in the function comment that the session will be automatically saved when the response is written, and this parameter is reserved for future use or API consistency.

Copilot · 2026-01-11T14:34:27Z

+// Set stores a value in the session.
+// Returns an error if the session is not in the request context.


The documentation should clarify that sessions are automatically saved when the response is written via the saver middleware, and that this function only modifies the session in memory. Users might expect that calling Set immediately persists the session, but it doesn't - it only modifies the session object which is later saved automatically.

Copilot · 2026-01-11T14:34:28Z

+// Clear removes all values from the session.
+// Returns an error if the session is not in the request context.


The documentation should clarify that sessions are automatically saved when the response is written via the saver middleware, and that this function only modifies the session in memory. Add a note similar to the one in the Save function documentation to explain when/how the session is persisted.

Copilot · 2026-01-11T14:34:28Z

+			session.Set(r, w, "key", "value")
+
+			err := session.Save(r, w)
+			if err != nil {


The return value from session.Set is not checked for errors. While this call is unlikely to fail in this test context, it's a best practice to check all error returns in tests for consistency and to catch unexpected issues.

Suggested change

session.Set(r, w, "key", "value")

err := session.Save(r, w)

if err != nil {

if err := session.Set(r, w, "key", "value"); err != nil {

t.Errorf("Set failed: %v", err)

}

if err := session.Save(r, w); err != nil {

Copilot · 2026-01-11T14:34:28Z

+		})
+
+		s.HandleFunc("GET /set/{$}", func(w http.ResponseWriter, r *http.Request) {
+			session.Set(r, w, "persistent", "data")


The return value from session.Set is not checked for errors. While this call is unlikely to fail in this test context, it's a best practice to check all error returns in tests for consistency and to catch unexpected issues.

Suggested change

session.Set(r, w, "persistent", "data")

if err := session.Set(r, w, "persistent", "data"); err != nil {

t.Fatalf("Set failed: %v", err)

}

paganotoni requested a review from Copilot January 11, 2026 14:29

Copilot started reviewing on behalf of paganotoni January 11, 2026 14:30 View session

paganotoni merged commit 2c1572d into main Jan 11, 2026
5 checks passed

Copilot AI reviewed Jan 11, 2026

View reviewed changes

tatang26 deleted the feature-session-helpers branch April 17, 2026 13:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add session helper functions for value manipulation - #45

Add session helper functions for value manipulation#45
paganotoni merged 1 commit into
mainfrom
feature-session-helpers

paganotoni commented Jan 11, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 11, 2026

Uh oh!

Copilot AI Jan 11, 2026

Uh oh!

Copilot AI Jan 11, 2026

Uh oh!

Copilot AI Jan 11, 2026

Uh oh!

Copilot AI Jan 11, 2026

Uh oh!

Copilot AI Jan 11, 2026

Uh oh!

Copilot AI Jan 11, 2026

Uh oh!

Copilot AI Jan 11, 2026

Uh oh!

Copilot AI Jan 11, 2026

Uh oh!

Copilot AI Jan 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-			session.Delete(r, w, "to_delete")
+			if err := session.Delete(r, w, "to_delete"); err != nil {
+				t.Errorf("Delete failed: %v", err)
+			}

		_, exists1, _ := session.Get(r, "key1")
		_, exists2, _ := session.Get(r, "key2")

		// Delete removes a value from the session by key.
		// Returns an error if the session is not in the request context.

-			session.Set(r, w, "key1", "value1")
-			session.Set(r, w, "key2", "value2")
-			session.Set(r, w, "key3", "value3")
+			if err := session.Set(r, w, "key1", "value1"); err != nil {
+				t.Fatalf("Set failed: %v", err)
+			}
+			if err := session.Set(r, w, "key2", "value2"); err != nil {
+				t.Fatalf("Set failed: %v", err)
+			}
+			if err := session.Set(r, w, "key3", "value3"); err != nil {
+				t.Fatalf("Set failed: %v", err)
+			}

		// Set stores a value in the session.
		// Returns an error if the session is not in the request context.

		// Clear removes all values from the session.
		// Returns an error if the session is not in the request context.

Uh oh!

Conversation

paganotoni commented Jan 11, 2026

Summary

Motivation

Usage

Testing

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants