Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# Rust's output directory
target

# Cargo lock file
Cargo.lock

# Local settings
.soroban
.stellar
3 changes: 3 additions & 0 deletions contracts/.gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# Rust's output directory
target

# Cargo lock file
Cargo.lock

# Local settings
.soroban
.stellar
16 changes: 0 additions & 16 deletions contracts/course-registry/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,3 @@ soroban-sdk = { workspace = true }
[dev-dependencies]
soroban-sdk = { workspace = true, features = ["testutils"] }

[features]
testutils = ["soroban-sdk/testutils"]

[profile.release]
opt-level = "z"
overflow-checks = true
debug = 0
strip = "symbols"
debug-assertions = false
panic = "abort"
codegen-units = 1
lto = true

[profile.release-with-logs]
inherits = "release"
debug-assertions = true
17 changes: 17 additions & 0 deletions contracts/course-registry/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,23 @@ impl CourseRegistry {
.unwrap_or(0)
}

/// Returns true if the learner has completed all modules in the course.
pub fn is_course_finished(env: Env, learner: Address, id: u32) -> bool {
let course: Course = env
.storage()
.persistent()
.get(&DataKey::Course(id))
.expect("Course not found");

let progress: u32 = env
.storage()
.persistent()
.get(&DataKey::Progress(learner, id))
.unwrap_or(0);

progress >= course.total_modules
}

/// Returns the full details of a specific course.
///
/// # Arguments
Expand Down
91 changes: 90 additions & 1 deletion contracts/course-registry/src/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use soroban_sdk::{
Address, BytesN, Env,
};

use crate::{CourseRegistry, CourseRegistryClient};
use crate::{CourseRegistry, CourseRegistryClient, DataKey};

// ── Helpers ───────────────────────────────────────────────────────────────────

Expand Down Expand Up @@ -289,3 +289,92 @@ fn test_get_progress_returns_zero_when_unenrolled() {
let progress = client.get_progress(&learner, &id);
assert_eq!(progress, 0);
}

// ── is_course_finished tests ──────────────────────────────────────────────────

#[test]
fn test_is_course_finished_unenrolled_returns_false() {
let (env, client) = setup();
let admin = Address::generate(&env);
let instructor = Address::generate(&env);
let learner = Address::generate(&env);

client.initialize(&admin);
client.create_course(&admin, &instructor, &3, &dummy_hash(&env));

// Learner has no progress entry at all — should return false
assert!(!client.is_course_finished(&learner, &1));
}

#[test]
fn test_is_course_finished_partial_progress_returns_false() {
let (env, client) = setup();
let admin = Address::generate(&env);
let instructor = Address::generate(&env);
let learner = Address::generate(&env);

client.initialize(&admin);
client.create_course(&admin, &instructor, &5, &dummy_hash(&env));

// Manually write partial progress into storage
env.as_contract(&client.address, || {
env.storage()
.persistent()
.set(&DataKey::Progress(learner.clone(), 1), &3u32);
});

assert!(!client.is_course_finished(&learner, &1));
}

#[test]
fn test_is_course_finished_exact_progress_returns_true() {
let (env, client) = setup();
let admin = Address::generate(&env);
let instructor = Address::generate(&env);
let learner = Address::generate(&env);

client.initialize(&admin);
client.create_course(&admin, &instructor, &4, &dummy_hash(&env));

// Progress exactly equals total_modules
env.as_contract(&client.address, || {
env.storage()
.persistent()
.set(&DataKey::Progress(learner.clone(), 1), &4u32);
});

assert!(client.is_course_finished(&learner, &1));
}

#[test]
fn test_is_course_finished_excess_progress_returns_true() {
let (env, client) = setup();
let admin = Address::generate(&env);
let instructor = Address::generate(&env);
let learner = Address::generate(&env);

client.initialize(&admin);
client.create_course(&admin, &instructor, &3, &dummy_hash(&env));

// Progress exceeds total_modules (defensive edge case)
env.as_contract(&client.address, || {
env.storage()
.persistent()
.set(&DataKey::Progress(learner.clone(), 1), &99u32);
});

assert!(client.is_course_finished(&learner, &1));
}

#[test]
#[should_panic(expected = "Course not found")]
fn test_is_course_finished_invalid_course_panics() {
let (env, client) = setup();
let admin = Address::generate(&env);
let learner = Address::generate(&env);

client.initialize(&admin);

// Course ID 99 was never created
client.is_course_finished(&learner, &99);
}
Loading