Skip to content

[Domain] add recommended scenario drafts#250

Merged
learncold merged 12 commits into
mainfrom
codex/recommendation-drafts
May 16, 2026
Merged

[Domain] add recommended scenario drafts#250
learncold merged 12 commits into
mainfrom
codex/recommendation-drafts

Conversation

@SilverSupplier
Copy link
Copy Markdown
Collaborator

@SilverSupplier SilverSupplier commented May 15, 2026

Summary

  • Adds domain-backed recommendation candidate generation for reviewable Recommended scenario drafts.
  • Adds batch-result recommendation cards with evidence, artifact source, and expected improvement direction.
  • Preserves Recommended role, provenance, diff keys, unstaged state, and control changes through authoring and persistence.
  • Adds supporting recommendation evidence docs and keeps the branch diff whitespace-clean.

Related Issue

Area

  • Engine
  • Domain
  • Application
  • Docs
  • Build
  • Analysis
  • Chore

Architecture Check

  • I kept the dependency direction application -> domain -> engine.
  • I did not add Qt UI code to src/domain.
  • I did not add domain or application dependencies to src/engine.
  • I used src/ as the include root.

Verification

  • cmake --preset windows-debug (not run as a separate command; build preset reconfigured the existing tree)
  • cmake --build --preset build-no-app-debug
  • ctest --preset test-no-app-debug
  • cmake --build --preset build-debug
  • ctest --preset test-debug
  • git diff --check origin/codex/two-floor-demo-project...HEAD
  • Not run (reason below)

Risks / Follow-up

  • V1 creates reviewable drafts only; it does not auto-stage, auto-run, rerun, batch-run, or optimize.
  • Recommendations are conservative rule-based candidates and still require user review plus rerun validation.
  • Blocked-connection relief now requires bottleneck evidence on the same blocked connection.

@SilverSupplier SilverSupplier requested a review from learncold as a code owner May 15, 2026 16:54
@SilverSupplier SilverSupplier force-pushed the codex/recommendation-drafts branch from b9383cb to 4cdc996 Compare May 15, 2026 17:20
Base automatically changed from codex/two-floor-demo-project to main May 16, 2026 07:19
learncold added 2 commits May 17, 2026 00:11
…drafts

# Conflicts:
#	docs/alternative-recommendation-evidence.md
#	docs/alternative-recommendation-plan.md
#	src/application/MainWindow.cpp
#	tests/ScenarioSimulationSystemsTests.cpp
@learncold learncold merged commit 28b4617 into main May 16, 2026
2 checks passed
@learncold learncold deleted the codex/recommendation-drafts branch May 16, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants