Draft
Conversation
Initial websockets integration
Feat change log broadcasting
Merge latest unstable into websockets
Feat server sync js cleanup
Merge latest unstable into websockets
Fix bad merging of Makefile changes
Remove all make dependencies since they weren't being run anyway
Fix redis connection trying localhost in deployment
Added a healthcheck route for Daphne server.
Merge unstable into websockets
Merge unstable into websockets
rtibbles
reviewed
Mar 22, 2024
| .then(() => { | ||
| return this.table.bulkPut(tasks); | ||
| }); | ||
| let deletePromise = Promise.resolve(); |
Member
There was a problem hiding this comment.
I think this logic is preserving a single task of the type - rather than a single task per type per channel? This might cause weird behaviour if you're editing two channels at once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a reference PR to depict my GSoC22 work in one place.