Fix circular import breaking deploy#6036
Merged
rtibbles merged 1 commit intoJul 11, 2026
Merged
Conversation
…ar import The GCS storage backend imports utils.files at module load. files' top-level `from contentcuration.models import File / generate_object_storage_name` then re-entered a partially initialized contentcuration.models during app boot (DEFAULT_FILE_STORAGE=GCS), raising ImportError and crash-looping the pods. The test suite missed it: pytest imports models early, so models is complete before the storage modules load files. Move File and generate_object_storage_name imports into their call sites (create_file_from_contents, get_file_diff, get_thumbnail_encoding). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019ineqU2EGLAcWW2WPWR3mE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes deploy issue not shown by tests.
References
Clean up from #5995
AI usage
Had Claude quickly trace this from the log output in hotfixes