[OU-ADD] l10n_it: rename_xmlids for l10n_it_edi_withholding consolidation#35
Draft
dnplkndll wants to merge 1 commit into
Draft
[OU-ADD] l10n_it: rename_xmlids for l10n_it_edi_withholding consolidation#35dnplkndll wants to merge 1 commit into
dnplkndll wants to merge 1 commit into
Conversation
…tion rename_xmlids moves 10 records' ir_model_data ownership from l10n_it_edi_withholding to l10n_it (the withholding-tax module folds into base l10n_it in 19.0): 1 account.report + 1 column + 4 expressions + 4 lines. Without this, customer references via account.tax.tag_ids to the withholding line tags would dangle.
e5783f8 to
1cbc3c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sibling fix to #34 (the
l10n_it_edi_nddconsolidation intol10n_it_edi). The 19.0l10n_itmodule absorbs records that shipped underl10n_it_edi_withholdingin 18.0 — the withholding-tax module is folded into the base Italian-localization module.Records renamed via
rename_xmlids:account.report:withh_tax_report_itaccount.report.column:withh_tax_report_balanceaccount.report.expression: enasarco/withh × purchase/sale × _line_tagaccount.report.line: enasarco/withh × purchase/sale × _lineWithout this rename, customer references to the previous tax-report records (e.g.
tag_idsonaccount.taxpointing at the withholding line definitions) would be orphaned when Odoo's 19.0 install creates freshir_model_datarows pointing at new res_ids.The broader 19.0 tax-report refactor under
l10n_it's own xmlids (~50 NEW expressions/lines + ~110 DELs) is standard module-data XML handled by Odoo'supdate_db. No customer data references those records directly. The DEL ofl10n_it_law_referencechar onaccount.taxis informational text — standard module-upgrade flow handles the column drop.Draft fork PR — for review before upstreaming to OCA/OpenUpgrade.