refactor(cli): invite pack 抬头去重(#383)#391
Merged
Merged
Conversation
#383 优化 invite.ts:watch 与 participate 两个 join pack 的抬头(标题栏 + server/ channel/scope/charter)完全相同、只有模式标签不同,却各写一遍。抽成局部 packHeader(mode) 一处,去掉重复。 保守选择:只做输出不变的去重(m3 快照守护,字节一致)。不动 pack 正文——它的详尽度是 踩过的坑换来的(false-online #55/#60、TMPDIR #336、trellis #367、任务台账 #371), 激进精简会拿可靠性冒险,不值当。UX 分层若要做另议(见 #383 我的分析评论)。 验证:m3 快照无变化(证明输出字节一致)、cli 全过、tsc 干净。 Refs #383 Claude-Session: https://claude.ai/code/session_01PgxkZeqJmDge3dYe9W2tPZ
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#383 优化 invite.ts:watch / participate 两个 join pack 的抬头(标题+server/channel/scope/charter)完全相同、只模式标签不同,抽成 packHeader(mode) 一处去重。
保守选择:只做输出不变的去重(m3 快照守护,字节一致)。不动 pack 正文——其详尽度是踩坑换来的(false-online/TMPDIR/trellis/任务台账),激进精简拿可靠性冒险不值当。UX 分层若要做另议。
m3 快照无变化(输出字节一致)、cli 全过、tsc 干净。
Refs #383