Open
Conversation
Since Ruby 3, hash passed as kwargs will be removed if empty.
This can result in a value of `{}` being converted to `nil`,
ultimately leading to a validation error.
Owner
Author
|
This PR in my fork of the GraphQL gem adds support for the two little fixes (and misc tidy-ups) to parse the federated schema #1 |
…rguments track deprecated arguments alongside deprecated fields
Add multi-tenant support for subscriptions
Update wording of the `max_page_size` option to include database limit
Refinements have a very significant performance overhead. The simple fact of refining a method, even if the refinement is never used will make calls to that method 40% slower. On rarely called methods in doesn't matter that much, but graphql-ruby refine some common String methods, so any project including the gem suffer from a significant performance penalty. See this benchmark for more details: https://gist.github.com/casperisfine/1c46f05cccfa945cd156f445f0d3d6fa
Avoid refining String when not necessary
Ensures numbers are parsed with base 10 in BigInt - Issue rmosolgo#3585
Relay 11 fix, remove request as a dependency
Automatically support Mongoid 7.3
Update position of keyword argument in doc example
Sketch out a general-use dataloader API
Properly detect input objects for authorization
Ruby 3: Don't pass empty hash as kwargs
Add support for apollo client:codegen --target json files
> Default implementation returns the root object. - Subscription#update returns root object by default - Subscription#subscribe returns :no_response by default So this line seems to be a typo for Subscription#subscirbe.
Fix typo for Subscription#subscribe documentation
Due to the error, this must be looks like this change
Fix for syntax error in doc
This commit aims to solve the issue rmosolgo#3619 - providing a query argument of an incorrect type would yield a `NoMethodError` due to the incorrect type argument to be allowed through to the lexer (which assumes it to be a string). As this parameter is, more often than not, feed from an external source (e.g. a web request), this commit assumes a more defensive approach and ensures that when the `GraphQL::Query` is initialized, the query string is indeed of the correct type (a string). As discussed in the issue, an `ArgumentError` is raised when a type mismatch is identified.
Suggest using rails/globalid for object identification
…-weight Add missing font-weight to guides
…y-request-exception Assert that query is a string on GraphQL::Query#initialize
equals or any members This still fails our exemplaray tests, but the error is now on the repeatable keyword.
…owing" This reverts commit 746c9b5.
This reverts commit efc97ec.
… to docs explaining this choice
leehambley
force-pushed
the
add-support-for-apollo-federated-schema
branch
from
8f909db to
a3b96f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ I don't expect this PR to go upstream. I have made it possible to parse "invalid" GraphQL syntax, see below:
The parser probably should parse "invalid" unions. The GraphQL spec provides a grammar which permits empty unions, and then a separate section which dictates that this is invalid. I have modified the parser to accept the same grammar as the GraphQL spec, but I have not added a check for "invalid" (i.e empty) unions.