fix(shared): strip triage-landing's unreachable superseded-research arm#519
Merged
Conversation
This was referenced Jul 23, 2026
Merged
Merged
leeovery
force-pushed
the
fix/review-entry-upstream-prose
branch
from
July 23, 2026 10:58
53db516 to
578a11a
Compare
leeovery
force-pushed
the
fix/triage-superseded-strip
branch
from
July 23, 2026 10:58
ea49972 to
0b5fde8
Compare
leeovery
force-pushed
the
fix/review-entry-upstream-prose
branch
from
July 23, 2026 11:05
578a11a to
1e113ba
Compare
leeovery
force-pushed
the
fix/triage-superseded-strip
branch
from
July 23, 2026 11:05
0b5fde8 to
c91eb0a
Compare
leeovery
force-pushed
the
fix/review-entry-upstream-prose
branch
from
July 23, 2026 12:29
1e113ba to
16206b7
Compare
leeovery
force-pushed
the
fix/triage-superseded-strip
branch
from
July 23, 2026 12:29
c91eb0a to
b9e62e6
Compare
leeovery
force-pushed
the
fix/review-entry-upstream-prose
branch
from
July 23, 2026 12:30
16206b7 to
ac2b3da
Compare
leeovery
force-pushed
the
fix/triage-superseded-strip
branch
from
July 23, 2026 12:30
b9e62e6 to
3bb9cd7
Compare
leeovery
force-pushed
the
fix/review-entry-upstream-prose
branch
from
July 23, 2026 12:31
ac2b3da to
7145675
Compare
leeovery
force-pushed
the
fix/triage-superseded-strip
branch
from
July 23, 2026 12:31
3bb9cd7 to
fe451bc
Compare
leeovery
force-pushed
the
fix/review-entry-upstream-prose
branch
from
July 23, 2026 12:32
7145675 to
4bc41b5
Compare
leeovery
force-pushed
the
fix/triage-superseded-strip
branch
from
July 23, 2026 12:32
fe451bc to
820ae9c
Compare
leeovery
force-pushed
the
fix/review-entry-upstream-prose
branch
from
July 23, 2026 12:33
4bc41b5 to
6ecc01c
Compare
leeovery
force-pushed
the
fix/triage-superseded-strip
branch
from
July 23, 2026 12:33
820ae9c to
354c6f9
Compare
leeovery
force-pushed
the
fix/review-entry-upstream-prose
branch
from
July 23, 2026 12:33
6ecc01c to
9d44385
Compare
leeovery
force-pushed
the
fix/triage-superseded-strip
branch
from
July 23, 2026 12:33
354c6f9 to
42860f1
Compare
leeovery
force-pushed
the
fix/review-entry-upstream-prose
branch
from
July 23, 2026 12:34
9d44385 to
e180d23
Compare
leeovery
force-pushed
the
fix/triage-superseded-strip
branch
from
July 23, 2026 12:34
42860f1 to
29e19da
Compare
leeovery
force-pushed
the
fix/review-entry-upstream-prose
branch
from
July 23, 2026 12:35
e180d23 to
d8d94ac
Compare
leeovery
force-pushed
the
fix/triage-superseded-strip
branch
from
July 23, 2026 12:35
29e19da to
a400c27
Compare
leeovery
force-pushed
the
fix/review-entry-upstream-prose
branch
from
July 23, 2026 12:35
d8d94ac to
bcbde15
Compare
leeovery
force-pushed
the
fix/triage-superseded-strip
branch
from
July 23, 2026 12:35
a400c27 to
72a24c7
Compare
leeovery
force-pushed
the
fix/review-entry-upstream-prose
branch
from
July 23, 2026 12:36
bcbde15 to
c556807
Compare
leeovery
force-pushed
the
fix/triage-superseded-strip
branch
from
July 23, 2026 12:36
72a24c7 to
3bde245
Compare
leeovery
force-pushed
the
fix/review-entry-upstream-prose
branch
from
July 23, 2026 12:36
c556807 to
369738c
Compare
leeovery
force-pushed
the
fix/triage-superseded-strip
branch
from
July 23, 2026 12:36
3bde245 to
43a5184
Compare
leeovery
force-pushed
the
fix/review-entry-upstream-prose
branch
from
July 23, 2026 12:37
369738c to
023c054
Compare
leeovery
force-pushed
the
fix/triage-superseded-strip
branch
from
July 23, 2026 12:37
43a5184 to
8a8ed23
Compare
The only producer of superseded research is the legacy split, which
renames the item to {source}-superseded-{datetime} and deletes its map
item — no triage target can ever name one. The arm was also mis-shaped
for that producer: it read superseded_by, which the split never sets
(a fan-out has no single absorbing topic), so the menu would
interpolate an empty name. Superseded now falls to the neither-live
branch, where topic start's loud refusal is the handler.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
leeovery
force-pushed
the
fix/triage-superseded-strip
branch
from
July 23, 2026 12:37
8a8ed23 to
03237e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
superseded_by) that research supersession doesn't have.workflow-legacy-research-split'sapply.cjs, which renames the item to{source}-superseded-{datetime}(never matching a map item, so triage can never target it) and supersedes via rawset status—superseded_byis never written. F was unreachable, and would interpolate an empty absorber name if it ever fired.ok: falsehandling surfaces the engine'stopic startrefusal verbatim — the code guard is the handler.Test plan
🤖 Generated with Claude Code
Stack