Skip to content

fix(shared): strip triage-landing's unreachable superseded-research arm#519

Merged
leeovery merged 2 commits into
mainfrom
fix/triage-superseded-strip
Jul 23, 2026
Merged

fix(shared): strip triage-landing's unreachable superseded-research arm#519
leeovery merged 2 commits into
mainfrom
fix/triage-superseded-strip

Conversation

@leeovery

@leeovery leeovery commented Jul 23, 2026

Copy link
Copy Markdown
Owner

Summary

  • Chesterton check first: section F was added deliberately in r3: discovery and sessions — honest classification, visible agents #451's honest-classification pass, not legacy — but it models spec-style supersession (single absorber, superseded_by) that research supersession doesn't have.
  • The only producer of superseded research is workflow-legacy-research-split's apply.cjs, which renames the item to {source}-superseded-{datetime} (never matching a map item, so triage can never target it) and supersedes via raw set statussuperseded_by is never written. F was unreachable, and would interpolate an empty absorber name if it ever fired.
  • Stripped the classification branch and section F; renamed G→F. A superseded item now falls to the neither-live branch → Fresh Target, whose existing ok: false handling surfaces the engine's topic start refusal verbatim — the code guard is the handler.

Test plan

  • Conventions lint green.

🤖 Generated with Claude Code

Stack

  1. feat(engine): discovery-map add-batch — the harvest persists in one call (D7) #505
  2. feat(engine): manifest apply — batched set/delete across one work unit (D7) #506
  3. refactor(prose): task-map family folds onto existing batch forms (D7, stage 3) #507
  4. feat(engine): manifest set — two grammars, never mixed #508
  5. refactor(prose): dump/read folds — subtree gets replace per-topic loops (D7, stage 5) #509
  6. feat(engine): commit --plan — plan storage stages from recorded state (D7, stage 6) #510
  7. fix: batching-stack review round — re-resolve rewired, guards symmetric, hardening pinned #512
  8. fix: deep-dive round 2 — backbone rule flipped, pre-upgrade paths routed, flow bugs closed #513
  9. fix(review-r3): engine hardening + crash-resume seams #514
  10. feat(scoping): promotion routes through first-phase choice + bridge #515
  11. fix(spec): pin the bugfix source name to the topic #516
  12. fix(skills): gate-skip sentence accurate in gate-less phases #517
  13. fix(review-entry): name the real upstream — specification and plan #518
  14. fix(shared): strip triage-landing's unreachable superseded-research arm #519 👈 current
  15. feat(engine): refuse work-unit-level fields that shadow the phases tree #520
  16. fix(discovery): first-written briefs join the full brief lifecycle #521
  17. test(sim): pipeline simulation — engine driven end-to-end as a black box #522
  18. fix(round-4): review findings — backfill keying, ratchet evasion, pull guard #523

@leeovery
leeovery force-pushed the fix/review-entry-upstream-prose branch from 53db516 to 578a11a Compare July 23, 2026 10:58
@leeovery
leeovery force-pushed the fix/triage-superseded-strip branch from ea49972 to 0b5fde8 Compare July 23, 2026 10:58
@leeovery
leeovery force-pushed the fix/review-entry-upstream-prose branch from 578a11a to 1e113ba Compare July 23, 2026 11:05
@leeovery
leeovery force-pushed the fix/triage-superseded-strip branch from 0b5fde8 to c91eb0a Compare July 23, 2026 11:05
@leeovery
leeovery force-pushed the fix/review-entry-upstream-prose branch from 1e113ba to 16206b7 Compare July 23, 2026 12:29
@leeovery
leeovery force-pushed the fix/triage-superseded-strip branch from c91eb0a to b9e62e6 Compare July 23, 2026 12:29
@leeovery
leeovery force-pushed the fix/review-entry-upstream-prose branch from 16206b7 to ac2b3da Compare July 23, 2026 12:30
@leeovery
leeovery force-pushed the fix/triage-superseded-strip branch from b9e62e6 to 3bb9cd7 Compare July 23, 2026 12:30
@leeovery
leeovery force-pushed the fix/review-entry-upstream-prose branch from ac2b3da to 7145675 Compare July 23, 2026 12:31
@leeovery
leeovery force-pushed the fix/triage-superseded-strip branch from 3bb9cd7 to fe451bc Compare July 23, 2026 12:31
@leeovery
leeovery force-pushed the fix/review-entry-upstream-prose branch from 7145675 to 4bc41b5 Compare July 23, 2026 12:32
@leeovery
leeovery force-pushed the fix/triage-superseded-strip branch from fe451bc to 820ae9c Compare July 23, 2026 12:32
@leeovery
leeovery force-pushed the fix/review-entry-upstream-prose branch from 4bc41b5 to 6ecc01c Compare July 23, 2026 12:33
@leeovery
leeovery force-pushed the fix/triage-superseded-strip branch from 820ae9c to 354c6f9 Compare July 23, 2026 12:33
@leeovery
leeovery force-pushed the fix/review-entry-upstream-prose branch from 6ecc01c to 9d44385 Compare July 23, 2026 12:33
@leeovery
leeovery force-pushed the fix/triage-superseded-strip branch from 354c6f9 to 42860f1 Compare July 23, 2026 12:33
@leeovery
leeovery force-pushed the fix/review-entry-upstream-prose branch from 9d44385 to e180d23 Compare July 23, 2026 12:34
@leeovery
leeovery force-pushed the fix/triage-superseded-strip branch from 42860f1 to 29e19da Compare July 23, 2026 12:34
@leeovery
leeovery force-pushed the fix/review-entry-upstream-prose branch from e180d23 to d8d94ac Compare July 23, 2026 12:35
@leeovery
leeovery force-pushed the fix/triage-superseded-strip branch from 29e19da to a400c27 Compare July 23, 2026 12:35
@leeovery
leeovery force-pushed the fix/review-entry-upstream-prose branch from d8d94ac to bcbde15 Compare July 23, 2026 12:35
@leeovery
leeovery force-pushed the fix/triage-superseded-strip branch from a400c27 to 72a24c7 Compare July 23, 2026 12:35
@leeovery
leeovery force-pushed the fix/review-entry-upstream-prose branch from bcbde15 to c556807 Compare July 23, 2026 12:36
@leeovery
leeovery force-pushed the fix/triage-superseded-strip branch from 72a24c7 to 3bde245 Compare July 23, 2026 12:36
@leeovery
leeovery force-pushed the fix/review-entry-upstream-prose branch from c556807 to 369738c Compare July 23, 2026 12:36
@leeovery
leeovery force-pushed the fix/triage-superseded-strip branch from 3bde245 to 43a5184 Compare July 23, 2026 12:36
@leeovery
leeovery force-pushed the fix/review-entry-upstream-prose branch from 369738c to 023c054 Compare July 23, 2026 12:37
@leeovery
leeovery force-pushed the fix/triage-superseded-strip branch from 43a5184 to 8a8ed23 Compare July 23, 2026 12:37
@leeovery
leeovery changed the base branch from fix/review-entry-upstream-prose to main July 23, 2026 12:37
leeovery and others added 2 commits July 23, 2026 13:37
The only producer of superseded research is the legacy split, which
renames the item to {source}-superseded-{datetime} and deletes its map
item — no triage target can ever name one. The arm was also mis-shaped
for that producer: it read superseded_by, which the split never sets
(a fan-out has no single absorbing topic), so the menu would
interpolate an empty name. Superseded now falls to the neither-live
branch, where topic start's loud refusal is the handler.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@leeovery
leeovery force-pushed the fix/triage-superseded-strip branch from 8a8ed23 to 03237e5 Compare July 23, 2026 12:37
@leeovery
leeovery merged commit 6352ca1 into main Jul 23, 2026
@leeovery
leeovery deleted the fix/triage-superseded-strip branch July 23, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant