data/Makefile.am: put -- between end of option and mode#147
Merged
Conversation
Owner
|
kbd uses DCO. Please add https://github.com/legionus/kbd/blob/master/docs/process/howto-contribute.md#sending-patches |
Contributor
Author
|
kbd uses DCO. Please add `Signed-off-by` to the commit.
Already done thanks to the CI, just didn't also update the PR message.
|
Owner
|
@lanodan I don't see any changes in the commit message. |
POSIX comforming getopt(3) will stop parsing options at the mode argument (provided it doesn't starts with a dash). So prior to this change `--` would be taken as a file argument because getopt(3) already stopped. Signed-off-by: Haelwenn (lanodan) Monnier <contact@hacktivis.me>
lanodan
force-pushed
the
chmod-end-opts
branch
from
aef4fb5 to
51ee1d9
Compare
Contributor
Author
|
I guess I mixed it up with another PR, should have verified properly.
Fixed now.
|
Owner
|
Applied. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POSIX comforming getopt(3) will stop parsing options at the mode argument
(provided it doesn't starts with a dash).
So prior to this change
--would be taken as a file argumentbecause getopt(3) already stopped.