chore(terminal): bundle static terminal.so into release artifacts

[theangelperalta]

Summary

Makes the terminal extension actually work from a downloaded AppImage and macOS zip by shipping a self-contained, statically-linked terminal.so in both release bundles.

Stacked on #2204 ("remove committed terminal.so binaries"). Until that merges, this PR's diff includes its commits; review the top commit (bundle static terminal.so into release artifacts) here. Please merge #2204 first.

Why

Release bundles never shipped or loaded terminal.so:

• ffi.lisp resolves the lib via asdf:system-relative-pathname — the build machine's source tree, absent on a user's machine.
• The macOS build uses Shinmera's deploy, which only bundles a foreign library that is loaded at build time. The CI runner installs sbcl tree-sitter but not libvterm, so the dlopen failed (swallowed by ignore-errors) and deploy never recorded it.
• Even when bundled, a dynamic terminal.so referenced /opt/homebrew/.../libvterm.0.dylib by absolute path (verified via otool -L) and deploy does not follow the transitive libvterm dependency.

Approach — static libvterm

Compile terminal.so for releases with libvterm statically linked, producing one self-contained .so with no external libvterm dependency. Then bundling is trivial and identical in spirit on both platforms; no install_name_tool / patchelf / linuxdeploy --library relinking. libvterm is MIT, so static linking is license-clean. The existing extensions/terminal/Dockerfile{,.musl} already document the Linux static recipe.

Key mechanic: once terminal.so is loaded at build time, deploy bundles it next to the executable and reloads it by filename at boot — so a self-contained static .so "just works". No ffi.lisp / core changes are needed.

Changes

• scripts/build-terminal.lisp — LEM_TERMINAL_STATIC mode. macOS links libvterm.a directly (prefix from LIBVTERM_PREFIX, else brew --prefix libvterm); Linux wraps -lvterm in -Wl,-Bstatic. Default stays dynamic for source installs.
• macOS (scripts/macos-deploy.bash, .github/workflows/nightly-builds.yml) — brew install … libvterm; build the static helper before asdf:make :lem; assert terminal.so landed in Lem.app.
• Linux AppImage (docker/Dockerfile-AppImage, docker/make_appdir.sh) — apt-get install … libvterm-dev; build the static helper before asdf:make; AppRun already sets LD_LIBRARY_PATH=usr/lib; make_appdir.sh now asserts terminal.so reached usr/lib.

Test plan

• macOS arm64: LEM_TERMINAL_STATIC=1 make terminal-lib → otool -L shows no libvterm dependency (self-contained, 93 KB). Default make terminal-lib still dynamic-links libvterm.0.dylib.
• CI nightly-builds.yml (workflow_dispatch) builds both Linux + macOS green; the bundle assertions pass.
• Confirm Ubuntu 22.04 libvterm-dev provides libvterm.a for the -Wl,-Bstatic link (fallback: build libvterm from source as extensions/terminal/Dockerfile does).
• Download the nightly AppImage / macOS zip on a clean machine, open a *terminal* buffer, confirm a shell runs.
• make sdl2 / ncurses / webview (dynamic, source install) unaffected.

Refs #1964, #2060.

[code-contractor-app]

✅ Code Contractor Validation: PASSED

=== Contract: contract ===

✓ Code Contractor Validation Result
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

📋 Contract Source: Repository

📊 Statistics:
  Files Changed:    3
  Lines Added:      0
  Lines Deleted:    0
  Total Changed:    0
  Delete Ratio:     0.00 (0%)

Status: PASSED ✅

🤖 AI Providers:
  - codex — model: gpt-5.4

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
🎉 No violations detected. Great job!

📋 Contract Configuration: contract (Source: Repository)

version: 2

trigger:
  paths:
    - "extensions/**"
    - "frontends/**/*.lisp"
    - "src/**"
    - "tests/**"
    - "contrib/**"
    - "**/*.asd"
  head_branches:
    exclude:
      - 'revert-*'

validation:
  limits:
    max_total_changed_lines: 400
    max_delete_ratio: 0.5
    max_files_changed: 10
    severity: warning

  ai:
    system_prompt: |
      You are a senior Common Lisp engineer reviewing code for Lem editor.
      Lem is a text editor with multiple frontends (ncurses, SDL2, webview).
      Focus on maintainability, consistency with existing code, and Lem-specific conventions.
    rules:
      # === File Structure ===
      - name: defpackage_rule
        prompt: |
          First form must be `defpackage` or `uiop:define-package`.
          Package name should match filename (e.g., `foo.lisp` → `:lem-ext/foo` or `:lem-foo`).
          Extensions must use `lem-` prefix (e.g., `:lem-python-mode`).

      - name: file_structure_rule
        prompt: |
          File organization (top to bottom):
          1. defpackage
          2. defvar/defparameter declarations
          3. Key bindings (define-key, define-keys)
          4. Class/struct definitions
          5. Functions and commands

      # === Style ===
      - name: loop_keywords_rule
        prompt: |
          Loop keywords must use colons: `(loop :for x :in list :do ...)`
          NOT: `(loop for x in list do ...)`

      - name: naming_conventions_rule
        prompt: |
          Naming conventions:
          - Functions/variables: kebab-case (e.g., `find-buffer`)
          - Special variables: *earmuffs* (e.g., `*global-keymap*`)
          - Constants: +plus-signs+ (e.g., `+default-tab-size+`)
          - Predicates: -p suffix for functions (e.g., `buffer-modified-p`)
          - Do NOT use -p suffix for user-configurable variables

      # === Documentation ===
      - name: docstring_rule
        prompt: |
          Required docstrings for:
          - Exported functions, methods, classes
          - `define-command` (explain what the command does)
          - Generic functions (`:documentation` option)
          Important functions should explain "why", not just "what".
        severity: warning

      # === Lem-Specific ===
      - name: internal_symbol_rule
        prompt: |
          Use exported symbols from `lem` or `lem-core` package.
          Avoid `lem::internal-symbol` access.
          If internal access is necessary, document why.

      - name: error_handling_rule
        prompt: |
          - `error`: Internal/programming errors
          - `editor-error`: User-facing errors (displayed in echo area)
          Always use `editor-error` for messages shown to users.

      - name: frontend_interface_rule
        prompt: |
          Frontend-specific code must use `lem-if:*` protocol.
          Do not call frontend implementation directly from core.
        severity: warning

      # === Functional Style ===
      - name: functional_style_rule
        prompt: |
          Prefer explicit function arguments over dynamic variables.
          Avoid using `defvar` for state passed between functions.
          Exception: Well-documented cases like `*current-buffer*`.

      - name: dynamic_symbol_call_rule
        prompt: |
          Avoid `uiop:symbol-call`. Rethink architecture instead.
          If unavoidable, document the reason.

      # === Libraries ===
      - name: alexandria_usage_rule
        prompt: |
          Alexandria utilities allowed: `if-let`, `when-let`, `with-gensyms`, etc.
          Avoid: `alexandria:curry` (use explicit lambdas)
          Avoid: `alexandria-2:*` functions not yet used in codebase

      # === Macros ===
      - name: macro_style_rule
        prompt: |
          Keep macros small. For complex logic, use `call-with-*` pattern:
          ```lisp
          (defmacro with-foo (() &body body)
            `(call-with-foo (lambda () ,@body)))
          ```
          Prefer `list` over backquote outside macros.

📚 About Code Contractor

Declarative Code Standards That Learn and Improve

Define domain-specific validation rules in YAML.
Your contracts document team knowledge and evolve into more accurate AI enforcement.

Want this for your repo?
→ Install Code Contractor

[code-contractor-app]

Code Contractor validation passed ✅ — see the sticky comment for full results.