chore(terminal): remove duplicate build-failed defun#2206
Merged
theangelperalta merged 1 commit intoJun 3, 2026
Merged
Conversation
PRs lem-project#2204 and lem-project#2205 merged in the reverse of their stacking order (lem-project#2205, which contained lem-project#2204's commits, merged first; lem-project#2204 merged second). Because lem-project#2205 had added static-p/vterm-flags just above build-failed, the squash of lem-project#2204 re-applied the build-failed block instead of recognizing it as already present, leaving two identical definitions in build-terminal.lisp. Remove the duplicate. No behavior change (the copies were identical); this just silences the SBCL redefinition warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/build-terminal.lisponmainhas two identicalbuild-faileddefinitions. Removing the duplicate.
Cause
#2204 and #2205 were a stack but merged in reverse order: #2205 (which
contained #2204's commits) squash-merged first, then #2204 squash-merged on
top. Because #2205 had inserted
static-p/vterm-flagsjust abovebuild-failed, git's 3-way merge for #2204 re-applied thebuild-failedblock rather than detecting it as already present — producing the duplicate.
Impact
Functionally harmless (both copies are byte-identical), but SBCL emits a
redefinition warning when loading the script. This restores a single
definition.
Verified:
make terminal-libstill builds;grep -c 'defun build-failed'is now 1.