feat: in-game options panel with per-alert sound picker (#6) - #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6. Replaces the previously-stacked PR #7 (its base branch was deleted when #8 shipped v0.3.0).
Requested by deehoc via Discord DM:
What lands
Options.luamodule registered viaInterfaceOptions_AddCategory(TBC 2.5.6 API). Reachable via ESC → Interface → AddOns → BlasterMaster, or/blaster options(alias/blaster config).laser), Low HP Alarm (siren), Kill Jingle (oneUp), Level Up (fanfare), Crit (crit).PlaySoundFile.playSFXinBlasterMaster.luanow consultsBlasterMaster_GetSfxPath(role)first (readsBlasterMasterDB.sfxMap), falls back to the hardcodedSFXtable.BlasterMasterDB.sfxMappersists per role → filename mapping.critShadowrole from the panel.How it works
AUDIO_FILES[1..37]="Blaster Master SFX (i).wav"— Lua can'tls, so this is baked in. If new files are added later, updateAUDIO_FILESinOptions.lua.SFX 1..SFX 37. Post-MVP: friendly names once we know what each sound is.Not in this PR
PlaySoundFiledoesn't accept volume in this API).Ship with
!ship blastermasterafter smoke-testing that the panel opens and previews work.