fleet-ops: require docs-check on every active repo - #68
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
cpitzi
enabled auto-merge (squash)
July 25, 2026 19:47
This was referenced Jul 25, 2026
Closed
cpitzi
added a commit
that referenced
this pull request
Jul 25, 2026
require_checks_apply rebuilds the required_status_checks rule from required-checks.json and PUTs a wholesale replacement, so any context required live but absent from the file was silently dropped on the next --require-checks sweep — indistinguishable from a normal apply (#68 dropped `Compile and commit` on site-icecreamtofightwith-com this way; restored in #70). Diff live against the file before applying: report any context that would be removed, and refuse to apply unless run with the new --allow-check-removal opt-in, matching the existing unseen-context refusal. Also surface the reverse diff (live-not-in-file) in the read-only --check pass, alongside the existing missing-from-live report, so the file's lag behind live is visible before a sweep instead of after. Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
cpitzi
added a commit
that referenced
this pull request
Aug 14, 2026
* docs: reconstruct architecture decision records under docs/adr Add six ADRs recovered on 2026-08-13 from repo history, PRs/issues, CLAUDE.md, the incident register, and fleet session archives, plus the docs/adr/README.md index and an "Architecture decisions" link in the main README. Each record's status date is the original decision date; every issue/PR number, file path, and date was verified against this repo. Alternatives sections separate the options weighed at the time from clearly-labelled retrospective options, each honestly assessed. - 0001 fleet-ops in the org .github meta-repo (PR #4, 2026-06-20) - 0002 declarative Terraform settings-as-code (PR #82; #81 deferred) - 0003 merge gate as push allowlist, not ruleset bypass (#96-#98) - 0004 per-repo rulesets under the Free plan; org ruleset parked - 0005 the incident register publishes verbatim (2026-07-13 owner call) - 0006 required link checker from one shared resolver (#57/#66/#68) Closes #108 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Apply pre-merge review fixes to reconstructed ADRs Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: claude-runner[bot] <claude-runner[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Christopher Pitzi <cpitzi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maps the
docs-check / docs-checkcontext across all fifteen active repos, completing the fleet-wide rollout of the reusable from shared-workflows#28 and closing the gap #57 described: docs-only PRs merging having asserted nothing about the docs they changed.The context string is captured from live check-runs on all fifteen adoption PRs rather than derived from the caller job id, per the standing warning in this file that context names are not display names.
Coverage goes from 11 of 15 to 15 of 15, and the "intentionally unmapped" set is now empty. Adopting docs-check is what closed the last four.
brasenia,reference-checkerandrepo-templatepreviously had only advisory claude workflows and so had no context that could be required.shared-workflowswas a structural exception rather than an oversight: every workflow in it is aworkflow_callreusable, so nothing had ever run on its own PRs — it now dogfoods docs-check against its own markdown through a local path ref, which additionally means a change that breaks the resolver fails its own pull request.For the eleven already-mapped repos the new context is added alongside their existing ones; nothing was removed.
.githubis the exception worth noting: its local relative-link check was deleted in #67 and replaced by this shared one, so the fleet has a single link resolver instead of two copies drifting apart.A defect surfaced during the rollout and is worth recording here, since this file is where the deadlock-class traps are documented. Every one of the thirteen cross-repo callers failed on first run while the self-caller passed; the reusable resolved its tooling checkout from
github.workflow_ref, which is the entry workflow rather than the reusable, so external callers handed their own PR ref to a checkout of shared-workflows and gotcouldn't find remote ref refs/pull/N/merge. Fixed in shared-workflows#30 by usinggithub.job_workflow_ref. The failure is invisible to self-referential testing, which is why it survived review and merge — worth remembering when the next reusable ships.The enforcing
fleet-apply.sh --require-checksrun follows once this merges.