Adds CLI animation - #53
Conversation
…ith vhs to regenerate the animation
📝 WalkthroughWalkthroughAdds a VHS script that records a reproducible ChangesCLI demonstration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
cli.tape (2)
60-61: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd
Require dstrackto fail fast if the CLI is not installed.Since the tape records
dstrackcommands, requiring the executable ensures VHS will abort early rather than recording a series of "command not found" errors if the environment isn't set up correctly.♻️ Proposed refactor
Output docs/assets/cli.gif + +Require dstrack🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@cli.tape` around lines 60 - 61, Add Require dstrack near the top of the VHS tape before any recorded dstrack commands, so VHS fails immediately when the executable is unavailable while preserving the existing recording commands and output.
94-112: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueMerge the off-camera setup blocks to remove redundant state toggles.
There is no need to
Showand immediatelyHidethe terminal between setting the prompt and creating the dummy dataset. Combining these into a single hidden block simplifies the script and avoids unnecessary double screen clears (Ctrl+Landclear).♻️ Proposed refactor
-# --- off-camera setup: pin a reproducible prompt --- -Hide -Type `PROMPT='> '` -Enter -Ctrl+L -Show - -# --- setup configuration in tmp folder --- -Hide -Type "cd $(mktemp -d)" -Enter -Type "printf 'id,feature,label\n1,0.5,cat\n2,0.9,dog\n3,0.2,cat\n' > data.csv" -Enter -Type "export LOGNAME=user USER=user" -Enter -Type "clear" -Enter -Show +# --- off-camera setup: pin a reproducible prompt and create tmp folder --- +Hide +Type `PROMPT='> '` +Enter +Type "cd $(mktemp -d)" +Enter +Type "printf 'id,feature,label\n1,0.5,cat\n2,0.9,dog\n3,0.2,cat\n' > data.csv" +Enter +Type "export LOGNAME=user USER=user" +Enter +Ctrl+L +Show🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@cli.tape` around lines 94 - 112, Merge the off-camera setup sections around the PROMPT assignment and temporary dataset creation into one hidden block, removing the intermediate Show/Hide toggles and redundant screen-clearing commands while preserving the setup commands and their execution order.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@cli.tape`:
- Around line 60-61: Add Require dstrack near the top of the VHS tape before any
recorded dstrack commands, so VHS fails immediately when the executable is
unavailable while preserving the existing recording commands and output.
- Around line 94-112: Merge the off-camera setup sections around the PROMPT
assignment and temporary dataset creation into one hidden block, removing the
intermediate Show/Hide toggles and redundant screen-clearing commands while
preserving the setup commands and their execution order.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 5af29cb6-ee8a-4fbc-b36c-b824ce6bde8b
⛔ Files ignored due to path filters (1)
docs/assets/cli.gifis excluded by!**/*.gif
📒 Files selected for processing (3)
README.mdcli.tapedocs/index.md
Summary
Adds CLI animation as an example together with the tape file to use with vhs to regenerate the animation.
Changes
Test plan
uv run pytestpassesSummary by CodeRabbit