fix(doctor): look for a SQLite database where the application would open it - #1402
Merged
Conversation
…pen it A Drupal site serving fine was reported as having no database at all. Its 20 MB file sits at web/sites/default/files/.ht.sqlite, and the check looked one directory up, because it resolved the declared path against the project while Drupal resolves it against the document root it runs from. Laravel roots the same kind of path at the project, so nothing in a fixture caught it and the frameworks simply disagree. Both roots are checked now, and a database found at either is the site's. A file missing from all of them is still the finding it always was, and an empty one still asks for migrations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Drupal site serving fine was reported as having no database at all:
Its database is a 20 MB file at web/sites/default/files/.ht.sqlite. The check resolved the declared path against the project directory, and Drupal resolves it against the document root it runs from, so lerd looked one directory up from where the application opens it.
Laravel roots the same kind of path at the project, which is why no fixture caught this: a relative database path is relative to whatever the application calls its root, and the frameworks disagree.
Both roots are checked now, the project and the document root the definition declares, and a database found at either is the site's. A file missing from all of them is still the finding it always was, and an empty one still asks for migrations.
Found by running the doctor against a real Drupal site rather than a scratch project.
Closes #1392