feat: move the service ports editor into a tab - #754
Merged
Conversation
The services detail view groups its configuration surfaces as tabs now, logs, env, tuning, and the recently added tools tab. Port mappings were the exception, reachable only through the cog button in the header as a modal. That split was arbitrary once everything adjacent to it became a tab, and the cog was a weaker discovery point than a labelled tab. Ports is now a tab following the Tuning tab's shape, a dirty indicator with an explicit save and a revert, both appearing only once a field is edited. A successful save settles the dirty state back to clean through the normal services broadcast. The tab hides itself for workers the same way the cog was suppressed for them, and the published, secondary, and extra port logic carries over unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The services detail view groups its configuration surfaces as tabs now, logs, env, tuning, and the recently added tools tab. Port mappings were the odd one out, reachable only through the cog button in the header as a modal, which was both an arbitrary split and a weaker discovery point than a labelled tab.
Ports becomes a tab following the Tuning tab's shape, a dirty indicator with revert and save that appear only once a field is edited, settling back to clean on a successful save through the normal services broadcast. It hides itself for workers exactly as the cog was suppressed for them, and the published, secondary, and extra port logic is carried over unchanged.
Closes #753