each function is broken in strict mode

[eight04]

this is undefined in strict mode hence it throws a TypeError:

less.js/lib/less/functions/list.js

Line 74 in a84358d

false, false, this.index, this.currentFileInfo));

I guess it should pass this argument to the forEach method?

less.js/lib/less/functions/list.js

Line 92 in a84358d

});

}, this);

[rjgotten]

No. The forEach should use an arrow function, which preserves the parent scope's lexical this binding.

[matthew-dean]

@rjgotten The Less code-base is still written in ES5. There have been a few attempts to Babelify it, but no one has ever gotten it to the point of converting / testing to make sure the distributed files are (roughly) equivalent to pre-converted code. So arrow functions wouldn't yet be allowed in the codebase because they aren't converted.

But yes, this is mistake. Should have a var self = this or a bind statement.