chore: add test for number with underscore parsing#4406
Merged
matthew-dean merged 1 commit intoless:masterfrom Mar 9, 2026
Merged
chore: add test for number with underscore parsing#4406matthew-dean merged 1 commit intoless:masterfrom
matthew-dean merged 1 commit intoless:masterfrom
Conversation
In Less.js 2.6.0, parsing of dimensions changed so that `5_large` is seen as one value, instead of as a list containing "5" and "_large". In updating the Less.php port, we forgot to consider this change because none of the Less.js 3.13 tests seem to cover this behavior. Follows-up less#2485. This adds the test case from less#2462, as inpired by downstream https://gerrit.wikimedia.org/r/1197310.
3 tasks
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo test data files receive additive styling rules for a new icon type. A CSS class and its Less variable counterpart are introduced to define styling for a "5_large" icon variant, with no modifications to existing rules. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased version of #4374 by @Krinkle. Resolves conflicts with current master.
The original PR targeted the old test file locations (
packages/test-data/css/_main/variables.cssandpackages/test-data/less/_main/variables.less), which were reorganized in #4378. This rebased version applies the same test additions to the new locations (packages/test-data/tests-unit/variables/).Original PR: #4374
Credit: @Krinkle
Summary by CodeRabbit