[Cleanup] Move WebServer_*.ino files (and some more) to .cpp/.h#3307
Merged
TD-er merged 27 commits intoletscontrolit:megafrom Oct 22, 2020
Merged
[Cleanup] Move WebServer_*.ino files (and some more) to .cpp/.h#3307TD-er merged 27 commits intoletscontrolit:megafrom
TD-er merged 27 commits intoletscontrolit:megafrom
Conversation
Member
Author
|
It appeared the So now all .h and .cpp files depending on defines like |
3baf7b2 to
37a2b0e
Compare
37a2b0e to
cb04c67
Compare
Not finished yet.
To be able to build again in Windows as the linker command exceeds max. command argument length in Windows.
The USES_xxx defines depend on the build config, so you need to include this _Plugin_Helper.h first before checking the `#ifdef USES_xxx`
b50c14f to
019012d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since PlatformIO 5.0 the build environment crashes quite often in VS code as it was generating a temp .cpp file from all .ino files.
This process, combined with Intellisense indexing this file, lead to lots of Extension Host crashes as it ran out of memory.
To keep on working on ESPEasy development, it is needed to convert the .ino files to .cpp/.h files.
Not only does it no longer lead to crashes during development, but also the builds are way more predictable compared to when using .ino files.
When compiling .ino files, there is no guarantee which order they will be compiled and thus it is also not guaranteed the needed defines are set correct.
This has led to numerous issues in the past.